From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: ak4642: Add Playback Volume control
Date: Mon, 28 Jun 2010 09:47:09 +0100 [thread overview]
Message-ID: <20100628084709.GA14247@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <w3pfx07svmu.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Jun 28, 2010 at 12:07:05PM +0900, Kuninori Morimoto wrote:
> Manual said this register name is "Digital Volume Control".
> In this case, should I use "Digital Playback Volume" ?
> or "Master Playback Volume" ?
Either is fine.
> > +static const DECLARE_TLV_DB_SCALE(out_tlv, -11500, 50, 1);
> Is this -11500 correct ?
> it should be -11550 ?
Should be -11600. You can check this by using an application like
alsamixer and looking at the dB values displayed in the UI.
> > +static const struct snd_kcontrol_new ak4642_snd_controls[] = {
> > + SOC_DOUBLE_R_TLV("Playback Volume", L_DVC, R_DVC,
> > + 0, 0xFF, 1, out_tlv),
> And here, Is 0xFF correct here ?
> Is it 0xFE ?
No, 0xff is still a valid value.
next prev parent reply other threads:[~2010-06-28 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 7:57 [PATCH] ASoC: ak4642: Add Playback Volume control Kuninori Morimoto
2010-06-25 10:50 ` Liam Girdwood
2010-06-28 0:30 ` Kuninori Morimoto
2010-06-28 3:07 ` Kuninori Morimoto
2010-06-28 8:47 ` Mark Brown [this message]
2010-06-28 3:10 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628084709.GA14247@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).