From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: alsa-devel@alsa-project.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH] ASoC: SAMSUNG: Add Aquila sound driver
Date: Thu, 8 Jul 2010 16:05:51 +0900 [thread overview]
Message-ID: <20100708070549.GA29850@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4C355AC2.8090502@samsung.com>
On Thu, Jul 08, 2010 at 01:57:38PM +0900, Chanwoo Choi wrote:
> This patch add sound support for the Aquila board based on S5PC110.
>
> The Aquila board is based on Samsung SoC(S5PC110) and include
> WM8994 codec over I2Sv5 to support sound. As there is currently
> no driver for the I2Sv5, the code to use I2Sv5 is deleted
> on this patch.
This looks good from my point of view, though I'm not sure if you want
to do any updates for Jassi's comments and Liam also needs to review
still.
One other thing that you might want to do - I'm not sure if you noticed
but there is now an API call snd_soc_dapm_ignore_suspend() which allows
audio paths to be kept up while the system is suspended, intended for
use in cases like voice calls on mobile phones where audio is running
even though the Linux system is suspended. To use this you should mark
all DAPM endpoints which can be live over suspend as ignoring suspend
then ASoC should transparently keep any paths between endpoints marked
this way up.
next prev parent reply other threads:[~2010-07-08 7:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 4:57 [PATCH] ASoC: SAMSUNG: Add Aquila sound driver Chanwoo Choi
2010-07-08 5:52 ` Jassi Brar
2010-07-08 8:10 ` Chanwoo Choi
2010-07-08 8:19 ` Jassi Brar
2010-07-09 1:06 ` Chanwoo Choi
2010-07-09 2:17 ` Jassi Brar
2010-07-08 7:05 ` Mark Brown [this message]
2010-07-09 2:21 ` Chanwoo Choi
2010-07-09 2:42 ` Mark Brown
2010-07-09 3:55 ` Chanwoo Choi
2010-07-12 7:23 ` Chanwoo Choi
2010-07-12 9:41 ` Mark Brown
2010-07-09 9:15 ` Liam Girdwood
-- strict thread matches above, loose matches on Subject: below --
2010-07-07 8:41 최찬우
2010-07-07 13:36 ` Mark Brown
2010-07-08 1:51 ` 최찬우
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708070549.GA29850@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=cw00.choi@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).