* [PATCH] ASoC: TWL4030: Fix for digital loopback gain range
@ 2010-07-12 8:50 Peter Ujfalusi
2010-07-12 8:51 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Peter Ujfalusi @ 2010-07-12 8:50 UTC (permalink / raw)
To: alsa-devel; +Cc: broonie, lrg
When the gain is configured using dB value it was
not possible to use -24dB since the loopback got
muted instead of -24dB.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
sound/soc/codecs/twl4030.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 8d36bfa..d7f0048 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -540,10 +540,11 @@ static const struct snd_kcontrol_new twl4030_dapm_abypassl2_control =
static const struct snd_kcontrol_new twl4030_dapm_abypassv_control =
SOC_DAPM_SINGLE("Switch", TWL4030_REG_VDL_APGA_CTL, 2, 1, 0);
-/* Digital bypass gain, 0 mutes the bypass */
+/* Digital bypass gain, mute instead of -30dB */
static const unsigned int twl4030_dapm_dbypass_tlv[] = {
- TLV_DB_RANGE_HEAD(2),
- 0, 3, TLV_DB_SCALE_ITEM(-2400, 0, 1),
+ TLV_DB_RANGE_HEAD(3),
+ 0, 1, TLV_DB_SCALE_ITEM(-3000, 600, 1),
+ 2, 3, TLV_DB_SCALE_ITEM(-2400, 0, 0),
4, 7, TLV_DB_SCALE_ITEM(-1800, 600, 0),
};
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: TWL4030: Fix for digital loopback gain range
2010-07-12 8:50 [PATCH] ASoC: TWL4030: Fix for digital loopback gain range Peter Ujfalusi
@ 2010-07-12 8:51 ` Mark Brown
2010-07-13 10:32 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2010-07-12 8:51 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, lrg
On Mon, Jul 12, 2010 at 11:50:06AM +0300, Peter Ujfalusi wrote:
> When the gain is configured using dB value it was
> not possible to use -24dB since the loopback got
> muted instead of -24dB.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: TWL4030: Fix for digital loopback gain range
2010-07-12 8:51 ` Mark Brown
@ 2010-07-13 10:32 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-07-13 10:32 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Peter Ujfalusi
On Mon, 2010-07-12 at 09:51 +0100, Mark Brown wrote:
> On Mon, Jul 12, 2010 at 11:50:06AM +0300, Peter Ujfalusi wrote:
> > When the gain is configured using dB value it was
> > not possible to use -24dB since the loopback got
> > muted instead of -24dB.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-13 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-12 8:50 [PATCH] ASoC: TWL4030: Fix for digital loopback gain range Peter Ujfalusi
2010-07-12 8:51 ` Mark Brown
2010-07-13 10:32 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).