From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/8] ASoC: fsi: modify format area definition on flags Date: Mon, 12 Jul 2010 09:54:19 +0100 Message-ID: <20100712085419.GB21840@rakim.wolfsonmicro.main> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id CF74424679 for ; Mon, 12 Jul 2010 10:54:20 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto Cc: Linux-ALSA List-Id: alsa-devel@alsa-project.org On Mon, Jul 12, 2010 at 02:55:53PM +0900, Kuninori Morimoto wrote: > +#define SH_FSI_FMT_MONO_DELAY (2 << 0) > +#define SH_FSI_FMT_PCM (3 << 0) > +#define SH_FSI_FMT_I2S (4 << 0) > +#define SH_FSI_FMT_TDM (5 << 0) > +#define SH_FSI_FMT_TDM_DELAY (6 << 0) Wouldn't it be clearer to just define these as straight numbers?