From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 5/8] ASoC: fsi: modify wrong value setting order of TDM
Date: Mon, 12 Jul 2010 10:00:14 +0100 [thread overview]
Message-ID: <20100712090014.GC21840@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <w3pk4p1dz0f.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Jul 12, 2010 at 02:56:17PM +0900, Kuninori Morimoto wrote:
> channel size should be set before setting register value
So, this looks like a bug fix which should go into 2.6.35 but...
> case SH_FSI_FMT_TDM:
> - data = CR_TDM | (fsi->chan - 1);
> fsi->chan = is_play ?
> SH_FSI_GET_CH_O(flags) : SH_FSI_GET_CH_I(flags);
> + data = CR_TDM | (fsi->chan - 1);
> break;
...it depends on your earlier patch to change the CR_ macros which is
just a coding style tweak and so should wait for 2.6.36.
When preparing patches it's good to separate out things like cleanups
and new features from bug fixes - the bug fixes we want to get into the
next release if possible, but other things are supposed to wait for the
next kernel development cycle.
next prev parent reply other threads:[~2010-07-12 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 5:54 [PATCH 0/8] ASoC: fsi: fixup patches Kuninori Morimoto
2010-07-12 5:55 ` [PATCH 1/8] ASoC: fsi: modify format area definition on flags Kuninori Morimoto
2010-07-12 8:54 ` Mark Brown
2010-07-13 1:22 ` Kuninori Morimoto
2010-07-13 8:55 ` Mark Brown
2010-07-13 9:08 ` Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 2/8] ASoC: fsi: fixup clock inversion operation Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 3/8] ASoC: fsi: remove un-used variable on fsi_dai_startup Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 4/8] ASoC: fsi: remove noisy CR_FMT macro Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 5/8] ASoC: fsi: modify wrong value setting order of TDM Kuninori Morimoto, Kuninori Morimoto
2010-07-12 9:00 ` Mark Brown [this message]
2010-07-12 5:56 ` [PATCH 6/8] ASoC: fsi: Change struct fsi_regs to fsi_core Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 7/8] ASoC: fsi: Add pr_err for noticing unsupported access Kuninori Morimoto, Kuninori Morimoto
2010-07-12 5:56 ` [PATCH 8/8] ASoC: fsi: Fixup for master mode Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712090014.GC21840@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).