From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, "lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 0/3] ASoC: twl4030/tpa6130a2:?DB_RANGE mapping fixes
Date: Mon, 19 Jul 2010 09:51:41 +0100 [thread overview]
Message-ID: <20100719085140.GA15693@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <201007190857.05339.peter.ujfalusi@nokia.com>
On Mon, Jul 19, 2010 at 08:57:05AM +0300, Peter Ujfalusi wrote:
> On Friday 16 July 2010 15:33:25 ext Mark Brown wrote:
> > Isn't this going to get messy when the increments don't line up so that
> > it's easy to overlap the start of one range with the beginning of the
> > next?
> Well, I assume however writes the driver knows how to build up a lookup table
> which is consistent, so I don't really see a problem.
The problem I see is if the hardware step sizes result in discontinuties
in the scale so you can't easily join the top end of one set of values
with the bottom end of another you're pretty stuck - joining the ranges
up will only work if they can be made to overlap which isn't always
going to be the case.
For example, something like:
1: 0
2: 2
3: 4
4: 5
5: 7
6: 9
(a bit artificial but you get the idea) is going to be a bit tricky.
> I'll post patches against alsa-lib to fix the _DB_RANGE handling. It will take
> some time to understand, and fix the code + testing it.
Thanks.
next prev parent reply other threads:[~2010-07-19 8:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 10:17 [PATCH 0/3] ASoC: twl4030/tpa6130a2: DB_RANGE mapping fixes Peter Ujfalusi
2010-07-16 10:17 ` [PATCH 1/3] ASoC: TWL4030: Fix DB_RANGE tlv mapping for digital loopback Peter Ujfalusi
2010-07-16 10:17 ` [PATCH 2/3] ASoC: tpa6130a2: Fix DB_RANGE mapping for tpa6130a2 chip Peter Ujfalusi
2010-07-16 10:17 ` [PATCH 3/3] ASoC: tpa6130a2: Fix DB_RANGE mapping for tpa6140a2 chip Peter Ujfalusi
2010-07-16 10:24 ` [PATCH 0/3] ASoC: twl4030/tpa6130a2: DB_RANGE mapping fixes Mark Brown
2010-07-16 11:05 ` Peter Ujfalusi
2010-07-16 12:33 ` [PATCH 0/3] ASoC: twl4030/tpa6130a2:?DB_RANGE " Mark Brown
2010-07-19 5:57 ` Peter Ujfalusi
2010-07-19 8:51 ` Mark Brown [this message]
2010-07-19 9:14 ` Peter Ujfalusi
2010-07-19 10:30 ` Mark Brown
2010-07-19 10:32 ` Peter Ujfalusi
2010-07-19 10:43 ` Peter Ujfalusi
2010-07-19 16:25 ` Takashi Iwai
2010-07-20 5:39 ` Peter Ujfalusi
2010-07-20 5:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719085140.GA15693@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).