From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
ext Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: ASoC: multi-component updates from RFC
Date: Thu, 22 Jul 2010 09:27:16 +0300 [thread overview]
Message-ID: <201007220927.16738.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1279715490.3072.51.camel@odin>
Hello Liam,
On Wednesday 21 July 2010 15:31:30 ext Liam Girdwood wrote:
...
> The only other change I've made is fixing the twl4030 and DAC33 codec
> probe and remove (as spotted by Peter).
I'm in the process of checking the changes.
For the twl4030 I have spotted the following:
1. twl-core registers "twl4030_codec" platform device.
2. The driver for this is the drivers/mfd/twl4030-codec.c
3. this MFD driver registers the following platform devices:
twl4030_codec_audio
twl4030_codec_vibra
4. the sound/soc/codecs/twl4030.c is the twl4030_codec_audio driver
5. the drivers/input/misc/twl4030-vibra.c is the twl4030_codec_vibra driver
Note: the platform data is propagated from board files to mfd/twl4030-codec.c,
than this mfd driver passes the appropriate platform data to the soc codec, and
vibra driver.
The codec part of twl40x0, twl50x0 has vibra and audio functionality, and they
have interoperability problems (sharing the same resources).
The name for the drivers/mfd/twl4030-codec.c is chosen, because the TRM refers
to this block as codec (audio + vibra).
We could go, and rename however this mfd driver to twl4030-audio (since the TRM
randomly refers to audio block instead of codec).
Than we can have twl4030-codec as device name for the soc codec, and twl4030-
vibra for the vibra.
I'll continue on checking the changes...
--
Péter
next prev parent reply other threads:[~2010-07-22 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 12:31 ASoC: multi-component updates from RFC Liam Girdwood
2010-07-22 6:27 ` Peter Ujfalusi [this message]
2010-07-22 8:18 ` Liam Girdwood
2010-07-22 13:07 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007220927.16738.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox