From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@slimlogic.co.uk
Subject: Re: [RFC 0/4] ASoC: OMAP3: Extended threshold mode
Date: Thu, 29 Jul 2010 12:03:51 +0300 [thread overview]
Message-ID: <20100729120351.9b05e482.jhnikula@gmail.com> (raw)
In-Reply-To: <1280386288-22019-1-git-send-email-peter.ujfalusi@nokia.com>
On Thu, 29 Jul 2010 09:51:24 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> Hello,
>
> The following series extends the current threshold implementation for OMAP3
> class of devices.
>
> The original threshold implementation has limitation on the size of the period,
> which can not be bigger than the McBSP port's FIFO size.
> This limitation makes it hard to use any power saving on McBSP ports other than
> McBSP2 (McBSP2 has 1280 word buffer, other ports have only 128 word long
> buffer), since the maximum period size limit is really small.
>
...
> What do you think?
>
Well, cleanups are always good as well as making the code more uniform,
and if the same set also improves power savings, what else I can do :-)
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
(this DMA packet transfer is used also with McPDM on OMAP4, trial
showed that it can work with McBSP on OMAP3 and as we can see, Peter
now implemented it)
next prev parent reply other threads:[~2010-07-29 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 6:51 [RFC 0/4] ASoC: OMAP3: Extended threshold mode Peter Ujfalusi
2010-07-29 6:51 ` [RFC 1/4] ASoC: omap-mcbsp: Code cleanup in omap_mcbsp_dai_hw_params Peter Ujfalusi
2010-07-29 6:51 ` [RFC 2/4] ASoC: omap-mcbsp: Restructure the code within omap_mcbsp_dai_hw_params Peter Ujfalusi
2010-07-29 6:51 ` [RFC 3/4] ASoC: omap-mcbsp: Support for sDMA packet mode Peter Ujfalusi
2010-07-29 6:51 ` [RFC 4/4] ASoC: omap-mcbsp: Remove period size constraint in THRESHOLD mode Peter Ujfalusi
2010-07-29 9:03 ` Jarkko Nikula [this message]
2010-07-29 17:22 ` [RFC 0/4] ASoC: OMAP3: Extended threshold mode Mark Brown
2010-08-02 9:43 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729120351.9b05e482.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).