From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2] ARM: S5PV210: Add the GPIO lib Date: Thu, 29 Jul 2010 10:40:39 -0700 Message-ID: <20100729174038.GF24781@opensource.wolfsonmicro.com> References: <4C4F9E4D.4090608@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 638D01039CE for ; Thu, 29 Jul 2010 19:40:25 +0200 (CEST) Content-Disposition: inline In-Reply-To: <4C4F9E4D.4090608@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Chanwoo Choi Cc: alsa-devel@alsa-project.org, Kukjin Kim , Joonyoung Shim , Ben Dooks , Kyungmin Park , linux-samsung-soc , linux-arm-kernel , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wed, Jul 28, 2010 at 12:04:45PM +0900, Chanwoo Choi wrote: > This patch add the definition of GPIO to support WM8994 audio codec on > I2C bus. > > Signed-off-by : Chanwoo Choi > Signed-off-by : Kyungmin Park This should come before the patch using it in your patch series, that way things won't break when people do git bisect and try to build the first patch without the second. The changelog could also do with a bit of a cleanup - this isn't something that's specific to a particular board, it's adding support for the GPIOs for whatever function they are needed on any board using this processor.