From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: alsa-devel@alsa-project.org, Kukjin Kim <kgene.kim@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Ben Dooks <ben@simtec.co.uk>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [alsa-devel] [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila
Date: Wed, 4 Aug 2010 09:19:38 +0100 [thread overview]
Message-ID: <20100804081938.GD22446@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4C5905D3.8090703@samsung.com>
On Wed, Aug 04, 2010 at 03:16:51PM +0900, Chanwoo Choi wrote:
> Mark Brown wrote:
> > OK, good - the fact that the connection wasn't being made with the PMIC
> > was my main point here.
> Did you read writed mail about consumer supply of WM8994 by MyungJoo Ham?
I saw it, yes.
> He is in charge of PMIC and Power Management on Aquila board.
> MyungJoo Ham is wrote :
> This aquila_buck3_data.constraints would be better have ".always_on =
> 1" entry as this buck3 is required to be turned on at all times in
> Aquila boards (even when the system is in suspend-to-mem state). This
> is required especially when there are many devices physically attached
> to Buck3 and some of they did not "register" as consumers to Buck3.
> Buck3 might be turned off by those who are registered while
> "unregistered" are still active.
> Can you tell me your opinion about the review by MyungJoo Ham?
> I will respect your response.
I think his comments are sensible. The constraints should always try to
reflect the actual constraints of the system as closely as possible.
next prev parent reply other threads:[~2010-08-04 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 3:04 [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila Chanwoo Choi
2010-07-29 17:38 ` Mark Brown
2010-07-30 7:15 ` Chanwoo Choi
2010-07-30 7:34 ` MyungJoo Ham
2010-08-03 8:59 ` Mark Brown
2010-08-04 6:16 ` [alsa-devel] " Chanwoo Choi
2010-08-04 8:19 ` Mark Brown [this message]
2010-09-29 12:16 ` Kukjin Kim
2010-09-30 1:23 ` Chanwoo Choi
2010-09-30 1:50 ` Kukjin Kim
2010-09-30 4:55 ` Chanwoo Choi
2010-07-29 22:48 ` Ben Dooks
2010-07-30 0:14 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804081938.GD22446@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben@simtec.co.uk \
--cc=cw00.choi@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).