alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 0/1] A codec driver for the TI WL1273 FM Radio.
@ 2010-08-05 10:43 Matti J. Aaltonen
  2010-08-05 10:43 ` [PATCH v5 1/1] ASoC: TI WL1273 FM Radio Codec Matti J. Aaltonen
  2010-08-05 13:30 ` [PATCH v5 0/1] A codec driver for the TI WL1273 FM Radio Liam Girdwood
  0 siblings, 2 replies; 4+ messages in thread
From: Matti J. Aaltonen @ 2010-08-05 10:43 UTC (permalink / raw)
  To: alsa-devel, broonie, lrg, peter.ujfalusi; +Cc: Matti J. Aaltonen

Hello.

New in the fifth version:

> > > +/* codec private data */
> > > +struct wl1273_priv {
> > > +   struct snd_soc_codec codec;
> > > +   enum wl1273_mode mode;
> > > +   struct wl1273_core *core;
> > > +   unsigned int channels;
> > > +};
> > 
> > ...why would anything outside the driver be peering into this?
> 
> Well, I see no reason... So I'll move it from the header to the c -file
> and then it's fine?

OK... that's most probably what you mean. So I've moved the private
struct definition from the header to the code file. And following the same
logic I also moved the mode enum definition.

Cheers,
Matti A.

Matti J. Aaltonen (1):
  ASoC: TI WL1273 FM Radio Codec.

 sound/soc/codecs/wl1273.c |  552 +++++++++++++++++++++++++++++++++++++++++++++
 sound/soc/codecs/wl1273.h |   30 +++
 2 files changed, 582 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/codecs/wl1273.c
 create mode 100644 sound/soc/codecs/wl1273.h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-08-05 13:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-05 10:43 [PATCH v5 0/1] A codec driver for the TI WL1273 FM Radio Matti J. Aaltonen
2010-08-05 10:43 ` [PATCH v5 1/1] ASoC: TI WL1273 FM Radio Codec Matti J. Aaltonen
2010-08-05 13:39   ` Mark Brown
2010-08-05 13:30 ` [PATCH v5 0/1] A codec driver for the TI WL1273 FM Radio Liam Girdwood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).