alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] asoc/multi-component: fsl: fix exit and error paths in DMA and SSI drivers
Date: Thu, 5 Aug 2010 06:52:31 -0700	[thread overview]
Message-ID: <20100805135231.GC14470@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1280876128-19263-1-git-send-email-timur@freescale.com>

On Tue, Aug 03, 2010 at 05:55:28PM -0500, Timur Tabi wrote:
> The error handling code in the OF probe function of the SSI driver is not
> freeing all resources correctly.
> 
> Since the machine driver no longer calls the DMA driver to provide information
> about the SSI, we don't need to keep a list of DMA objects any more.  In
> addition, the fsl_soc_dma_remove() function is incorrectly removing *all*
> DMA objects when it should only remove one.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

      parent reply	other threads:[~2010-08-05 13:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 22:55 [PATCH] asoc/multi-component: fsl: fix exit and error paths in DMA and SSI drivers Timur Tabi
2010-08-03 23:35 ` Liam Girdwood
2010-08-05 13:52 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100805135231.GC14470@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).