From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: jkrzyszt@tis.icnet.pl, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com, arunks@mistralsolutions.com,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 3/3] ASoC: multi-comp: OMAP2, 3, 4 McBSP: register correct number of ports
Date: Fri, 6 Aug 2010 11:08:08 +0300 [thread overview]
Message-ID: <20100806110808.8452ec7a.jhnikula@gmail.com> (raw)
In-Reply-To: <1281080355-22589-4-git-send-email-peter.ujfalusi@nokia.com>
On Fri, 6 Aug 2010 10:39:15 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> static void omap_init_audio(void)
> {
> platform_device_register(&omap_mcbsp1);
> platform_device_register(&omap_mcbsp2);
> +#ifdef OMAP_HAS_4_MCBSP_PORTS
> platform_device_register(&omap_mcbsp3);
> platform_device_register(&omap_mcbsp4);
> +#endif
> +#ifdef OMAP_HAS_5_MCBSP_PORTS
> platform_device_register(&omap_mcbsp5);
> +#endif
> platform_device_register(&omap_pcm);
> }
>
This must be done at runtime since we can have multi omap builds now.
So use cpu_is_omapxxx instead of conditional compilation. Simplifies
patch too :-)
--
Jarkko
next prev parent reply other threads:[~2010-08-06 8:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 7:39 [PATCH 0/3] ASoC: multi-comp: OMAP platform fixes Peter Ujfalusi
2010-08-06 7:39 ` [PATCH 1/3] ASoC: multi-comp: OMAP McBSP: use macro for platform_device Peter Ujfalusi
2010-08-06 7:39 ` [PATCH 2/3] ASoC: multi-comp: OMAP McBSP: Enable audio on OMAP1 platform Peter Ujfalusi
2010-08-06 7:50 ` Peter Ujfalusi
2010-08-06 7:58 ` Peter Ujfalusi
2010-08-06 8:13 ` Jarkko Nikula
2010-08-06 7:39 ` [PATCH 3/3] ASoC: multi-comp: OMAP2, 3, 4 McBSP: register correct number of ports Peter Ujfalusi
2010-08-06 8:08 ` Jarkko Nikula [this message]
2010-08-06 8:18 ` Peter Ujfalusi
2010-08-06 7:56 ` [PATCH 0/3] ASoC: multi-comp: OMAP platform fixes Jarkko Nikula
2010-08-07 2:11 ` Arun KS
2010-08-09 17:09 ` Janusz Krzysztofik
2010-08-09 18:38 ` Jarkko Nikula
2010-08-10 6:42 ` Peter Ujfalusi
2010-08-06 12:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100806110808.8452ec7a.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arunks@mistralsolutions.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).