From: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
To: Clemens Ladisch <clemens-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>,
Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Paul Zimmerman <Paul.Zimmerman-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Subject: Re: [alsa-devel] [PATCH] sound: usb: USB3 Super Speed patch
Date: Wed, 11 Aug 2010 11:36:58 +0200 [thread overview]
Message-ID: <20100811093658.GN17833@buzzloop.caiaq.de> (raw)
In-Reply-To: <4C624A15.206-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
On Wed, Aug 11, 2010 at 08:58:29AM +0200, Clemens Ladisch wrote:
> Paul Zimmerman wrote:
> > This patch adds Super Speed support to the USB drivers under sound/. It adds
> > tests for USB_SPEED_SUPER to all the places that check for the USB speed.
>
> > +++ b/sound/usb/midi.c
> > @@ -834,7 +834,8 @@ static void snd_usbmidi_us122l_output(struct snd_usb_midi_out_endpoint *ep,
> > +++ b/sound/usb/misc/ua101.c
> > +++ b/sound/usb/usx2y/us122l.c
> > +++ b/sound/usb/usx2y/usb_stream.c
>
> These devices do not support super speed.
>
> > +++ b/sound/usb/pcm.c
> > - if (snd_usb_get_speed(subs->dev) != USB_SPEED_HIGH)
> > + if (snd_usb_get_speed(subs->dev) != USB_SPEED_HIGH &&
> > + snd_usb_get_speed(subs->dev) != USB_SPEED_SUPER)
> > /* full speed devices have fixed data packet interval */
> > ptmin = 1000;
>
> In places like this, it would be better to write something like
> if (snd_usb_get_speed(subs->dev) == USB_SPEED_FULL)
> or
> if (snd_usb_get_speed(subs->dev) < USB_SPEED_HIGH)
Yep, or reconstruct the code to use switch-case statements.
Other than that, the patch looks fine to me.
Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-11 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F6C4814A9B336243ABC3D1FB44E08AE8012C2846E3@US01WXMBX1.internal.synopsys.com>
2010-08-11 6:58 ` [PATCH] sound: usb: USB3 Super Speed patch Clemens Ladisch
[not found] ` <4C624A15.206-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2010-08-11 7:34 ` [alsa-devel] " Daniel Mack
[not found] ` <20100811073443.GG10432-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-08-11 8:57 ` Takashi Iwai
2010-08-11 18:16 ` Paul Zimmerman
2010-08-11 9:36 ` Daniel Mack [this message]
2010-08-11 18:02 ` Paul Zimmerman
2010-08-11 8:58 ` Forward: " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100811093658.GN17833@buzzloop.caiaq.de \
--to=daniel-rduayeluppe@public.gmane.org \
--cc=Paul.Zimmerman-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=clemens-P6GI/4k7KOmELgA04lAiVw@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox