From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Randolph Chung <rchung42@gmail.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH v2] Add support for tlv320aic3007 to tlv320aic3x codec.
Date: Fri, 20 Aug 2010 12:08:41 +0100 [thread overview]
Message-ID: <20100820110840.GF13668@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1282279673-27319-1-git-send-email-rchung42@gmail.com>
On Fri, Aug 20, 2010 at 12:47:53PM +0800, Randolph Chung wrote:
> This patch adds support for the tlv320aic3007 codec to the tlv320aic3x
> driver.
>
> The tlv320aic3007 is similar to the aic31, but has an additional class-D
> speaker amp. The speaker amp control register overlaps with the mono
> output register of other codecs in this family, so we add logic to
> identify the actual codec being registered to set things up accordingly.
Applied but...
> +static const struct i2c_device_id aic3x_i2c_id[] = {
> + [AIC3X_MODEL_3X] = { "tlv320aic3x", 0 },
> + [AIC3X_MODEL_33] = { "tlv320aic33", 0 },
> + [AIC3X_MODEL_3007] = { "tlv320aic3007", 0 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, aic3x_i2c_id);
The more idiomatic way to write this stuff is:
{ "tlv320aic3007", AIC3X_MODEL_3007 }
and then look at the id field in the probe() function. Could you send a
followup patch doing that, please?
next prev parent reply other threads:[~2010-08-20 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 4:47 [PATCH v2] Add support for tlv320aic3007 to tlv320aic3x codec Randolph Chung
2010-08-20 10:39 ` Liam Girdwood
2010-08-20 11:08 ` Mark Brown [this message]
2010-08-20 14:58 ` Randolph Chung
2010-08-20 15:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820110840.GF13668@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rchung42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox