* ASoC i.MX ssi: use SSI_STCCR in synchronous mode
@ 2010-08-23 6:52 Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2010-08-23 6:52 UTC (permalink / raw)
To: alsa-devel
Hi,
Please consider applying this for -rc.
Sascha
In synchronous mode the SSI_SRCCR values are ignored. Instead
SSI_STCCR must be used for both receiving and transmitting.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
sound/soc/imx/imx-ssi.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/imx/imx-ssi.c b/sound/soc/imx/imx-ssi.c
index a11daa1..c81da05 100644
--- a/sound/soc/imx/imx-ssi.c
+++ b/sound/soc/imx/imx-ssi.c
@@ -254,6 +254,9 @@ static int imx_ssi_hw_params(struct snd_pcm_substream *substream,
dma_data = &ssi->dma_params_rx;
}
+ if (ssi->flags & IMX_SSI_SYN)
+ reg = SSI_STCCR;
+
snd_soc_dai_set_dma_data(cpu_dai, substream, dma_data);
sccr = readl(ssi->base + reg) & ~SSI_STCCR_WL_MASK;
--
1.7.1
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ASoC i.MX ssi: use SSI_STCCR in synchronous mode
@ 2010-08-23 6:54 Sascha Hauer
2010-08-23 10:38 ` Liam Girdwood
2010-08-23 12:34 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Sascha Hauer @ 2010-08-23 6:54 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Eric Bénard, Liam Girdwood
Hi,
This time with cc list.
Please consider applying for -rc.
Sascha
In synchronous mode the SSI_SRCCR values are ignored. Instead
SSI_STCCR must be used for both receiving and transmitting.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
sound/soc/imx/imx-ssi.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/imx/imx-ssi.c b/sound/soc/imx/imx-ssi.c
index a11daa1..c81da05 100644
--- a/sound/soc/imx/imx-ssi.c
+++ b/sound/soc/imx/imx-ssi.c
@@ -254,6 +254,9 @@ static int imx_ssi_hw_params(struct snd_pcm_substream *substream,
dma_data = &ssi->dma_params_rx;
}
+ if (ssi->flags & IMX_SSI_SYN)
+ reg = SSI_STCCR;
+
snd_soc_dai_set_dma_data(cpu_dai, substream, dma_data);
sccr = readl(ssi->base + reg) & ~SSI_STCCR_WL_MASK;
--
1.7.1
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: ASoC i.MX ssi: use SSI_STCCR in synchronous mode
2010-08-23 6:54 Sascha Hauer
@ 2010-08-23 10:38 ` Liam Girdwood
2010-08-23 12:34 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2010-08-23 10:38 UTC (permalink / raw)
To: Sascha Hauer; +Cc: alsa-devel, Mark Brown, Eric Bénard
On Mon, 2010-08-23 at 08:54 +0200, Sascha Hauer wrote:
> Hi,
>
> This time with cc list.
>
> Please consider applying for -rc.
>
> Sascha
>
>
> In synchronous mode the SSI_SRCCR values are ignored. Instead
> SSI_STCCR must be used for both receiving and transmitting.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> sound/soc/imx/imx-ssi.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/imx/imx-ssi.c b/sound/soc/imx/imx-ssi.c
> index a11daa1..c81da05 100644
> --- a/sound/soc/imx/imx-ssi.c
> +++ b/sound/soc/imx/imx-ssi.c
> @@ -254,6 +254,9 @@ static int imx_ssi_hw_params(struct snd_pcm_substream *substream,
> dma_data = &ssi->dma_params_rx;
> }
>
> + if (ssi->flags & IMX_SSI_SYN)
> + reg = SSI_STCCR;
> +
> snd_soc_dai_set_dma_data(cpu_dai, substream, dma_data);
>
> sccr = readl(ssi->base + reg) & ~SSI_STCCR_WL_MASK;
> --
> 1.7.1
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ASoC i.MX ssi: use SSI_STCCR in synchronous mode
2010-08-23 6:54 Sascha Hauer
2010-08-23 10:38 ` Liam Girdwood
@ 2010-08-23 12:34 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2010-08-23 12:34 UTC (permalink / raw)
To: Sascha Hauer; +Cc: alsa-devel, Eric Bénard, Liam Girdwood
On Mon, Aug 23, 2010 at 08:54:02AM +0200, Sascha Hauer wrote:
> Hi,
>
> This time with cc list.
>
> Please consider applying for -rc.
>
> Sascha
Applied, thanks. Please put stuff like this after the --- in the mail
(makes git am DTRT).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-23 12:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-23 6:52 ASoC i.MX ssi: use SSI_STCCR in synchronous mode Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2010-08-23 6:54 Sascha Hauer
2010-08-23 10:38 ` Liam Girdwood
2010-08-23 12:34 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).