From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] ASoC: uda1380: make driver more powersave-friendly
Date: Sat, 28 Aug 2010 09:56:36 +0100 [thread overview]
Message-ID: <20100828085627.GA9324@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1282981776-10014-2-git-send-email-anarsoul@gmail.com>
On Sat, Aug 28, 2010 at 10:49:35AM +0300, Vasily Khoruzhick wrote:
> Disable some codec modules in standby mode, completely disable
> codec in off mode to save some power.
> Fix suspend/resume: mark mixer regs as dirty on resume to
> restore mixer values, otherwise driver produces no sound
> (master is muted by default).
This sounds like there's a pre-existing bug where the register cache
defaults don't correspond to the chip defaults. In general we always
keep the initial chip defaults for user visible controls in the driver
and let the application layer set the values it wants. This avoids
having to worry about defaults being inappropriate for some systems (eg,
volumes far too loud or bad output path selection) - normally the chip
defaults will be reasonable for first power up.
The code itself looks good from a quick read through.
next prev parent reply other threads:[~2010-08-28 8:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 7:49 [PATCH 0/2] ASoC: Add iPAQ RX1950 sound support Vasily Khoruzhick
2010-08-28 7:49 ` [PATCH 1/2] ASoC: uda1380: make driver more powersave-friendly Vasily Khoruzhick
2010-08-28 8:56 ` Mark Brown [this message]
2010-08-28 9:07 ` Vasily Khoruzhick
2010-08-28 9:14 ` Mark Brown
2010-08-28 9:17 ` Vasily Khoruzhick
2010-08-28 11:34 ` [PATCH v2 " Vasily Khoruzhick
2010-08-28 7:49 ` [PATCH 2/2] ASoC: Add HP iPAQ RX1950 support Vasily Khoruzhick
2010-08-28 8:31 ` Vasily Khoruzhick
2010-08-28 8:37 ` [PATCH v2 " Vasily Khoruzhick
2010-08-28 8:46 ` Vasily Khoruzhick
2010-08-28 8:54 ` [PATCH v3 " Vasily Khoruzhick
2010-08-28 9:06 ` Mark Brown
2010-08-28 9:28 ` Vasily Khoruzhick
2010-08-31 10:45 ` Mark Brown
2010-08-28 11:37 ` Vasily Khoruzhick
2010-08-29 9:31 ` Vasily Khoruzhick
2010-08-29 13:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100828085627.GA9324@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).