Re: [PATCH v4 2/3] ASoC: Add HP iPAQ RX1950 support

From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Ben Dooks <ben-linux@fluff.org>,
	Philipp Zabel <philipp.zabel@gmail.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v4 2/3] ASoC: Add HP iPAQ RX1950 support
Date: Sun, 29 Aug 2010 21:15:26 +0300	[thread overview]
Message-ID: <201008292115.33770.anarsoul@gmail.com> (raw)
In-Reply-To: <201008291939.39530.marek.vasut@gmail.com>

[-- Attachment #1.1: Type: Text/Plain, Size: 1145 bytes --]

В сообщении от 29 августа 2010 20:39:39 автор Marek Vasut написал:

> > +static int rx1950_spk_power(struct snd_soc_dapm_widget *w,
> > +				struct snd_kcontrol *kcontrol, int event)
> > +{
> > +	if (SND_SOC_DAPM_EVENT_ON(event))
> > +		gpio_direction_output(S3C2410_GPA(1), 1);
> > +	else
> > +		gpio_direction_output(S3C2410_GPA(1), 0);
> 
> gpio_set_value()

Ok

> > +static int rx1950_uda1380_init(struct snd_soc_pcm_runtime *rtd)
> > +{
> > +	struct snd_soc_codec *codec = rtd->codec;
> > +	int err;
> > +
> > +	/* Add rx1950 specific widgets */
> > +	snd_soc_dapm_new_controls(codec, uda1380_dapm_widgets,
> > +				  ARRAY_SIZE(uda1380_dapm_widgets));
> > +
> > +	/* Set up rx1950 specific audio path audio_mapnects */
> > +	err = snd_soc_dapm_add_routes(codec, audio_map,
> > +				      ARRAY_SIZE(audio_map));
> > +
> 
> Handle return values

Ok

> > +	gpio_direction_output(S3C2410_GPA(1), 0);
> 
> Again, use gpio_set_value() after this and handle return value of
> gpio_direction_output().

Second arg is value, gpio_set_value is not required.

Regards
Vasily

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel