From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi sound support Date: Tue, 7 Sep 2010 10:40:48 +0100 Message-ID: <20100907094047.GA7886@rakim.wolfsonmicro.main> References: <20100906102557.GE10367@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 124C024485 for ; Tue, 7 Sep 2010 11:40:50 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Guennadi Liakhovetski Cc: Linux-ALSA , Paul Mundt , Liam Girdwood , Kuninori Morimoto , Linux-SH List-Id: alsa-devel@alsa-project.org On Tue, Sep 07, 2010 at 09:11:28AM +0200, Guennadi Liakhovetski wrote: > On Mon, 6 Sep 2010, Mark Brown wrote: > > > > +static int sh_hdmi_snd_write(struct snd_soc_codec *codec, > > > Are these two actually needed? As long as you don't have a register cache > > > - no need for these? > > Something needs to translate the ASoC register I/O functions into what > > the HDMI layer code is expecting. > AFAICS, with ->reg_cache_size = 0 the ASoC core will not attempt to call > them. Could you please be more explicit here? Register I/O needs to happen somehow...