From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 4/4] ASoC: tlv320aic3x: Let the codec hit SND_SOC_BIAS_OFF when idle
Date: Fri, 10 Sep 2010 13:00:17 +0100 [thread overview]
Message-ID: <20100910120016.GL7259@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1284117812-8618-4-git-send-email-jhnikula@gmail.com>
On Fri, Sep 10, 2010 at 02:23:32PM +0300, Jarkko Nikula wrote:
> - regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
> + if (aic3x->power)
> + regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies),
> + aic3x->supplies);
This looks suspicious - doesn't it mean that the enable/disables won't
be balanced any more? I'd expect to either see the disable being
uncondtional or the power flag being updated. I could be missing
something, though.
next prev parent reply other threads:[~2010-09-10 12:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 11:23 [PATCH 1/4] ASoC: tlv320aic3x: Optimize PLL programming in aic3x_set_bias_level Jarkko Nikula
2010-09-10 11:23 ` [PATCH 2/4] ASoC: tlv320aic3x: Add runtime regulator control to aic3x_set_bias_level Jarkko Nikula
2010-09-10 11:47 ` Mark Brown
2010-09-10 12:18 ` Jarkko Nikula
2010-09-10 11:23 ` [PATCH 3/4] ASoC: tlv320aic3x: Use regulator notifiers for optimizing the cache sync Jarkko Nikula
2010-09-10 11:58 ` Mark Brown
2010-09-10 12:33 ` Jarkko Nikula
2010-09-10 11:23 ` [PATCH 4/4] ASoC: tlv320aic3x: Let the codec hit SND_SOC_BIAS_OFF when idle Jarkko Nikula
2010-09-10 12:00 ` Mark Brown [this message]
2010-09-10 12:42 ` Jarkko Nikula
2010-09-10 11:36 ` [PATCH 1/4] ASoC: tlv320aic3x: Optimize PLL programming in aic3x_set_bias_level Mark Brown
2010-09-11 8:04 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910120016.GL7259@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox