From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Takashi Iwai <tiwai@suse.de>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jesse Marroquin <Jesse.Marroquin@maxim-ic.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver
Date: Wed, 22 Sep 2010 11:38:07 +0100 [thread overview]
Message-ID: <20100922103806.GC22361@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40D46E1B8E7@ITSVLEX06.it.maxim-ic.internal>
On Tue, Sep 21, 2010 at 07:49:30PM -0700, Peter Hsiang wrote:
> On Fri, Sep 03, 2010, Mark Brown wrote:
> > No, you should use the features of the current kernel. For your
> > backport you can do things like supply soc-cache.c as well.
> The soc-cache.c in the latest kernel-next version supports codecs
> with volatile registers in 16 bit mode, but not for the 8 bit mode.
> See snd_soc_8_8_write.
> The source code comments confirmed this:
> "Note at present this code can not be used by CODECs with
> volatile registers."
> For this codec (with volatile registers), should we use the read
> and write functions in the codec driver until the 8-bit mode is
> supported by Linux soc-cache.c?
You should modify soc-cache.c to support volatile registers if you need
this; it's not been implemented because nobody needed it yet (someone
may get to it before you get round to resubmitting, but if they haven't
then just extend the core functionality).
next prev parent reply other threads:[~2010-09-22 10:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <B2150E1E4418E1438554A300EA5040E40D469C123B@ITSVLEX06.it.maxim-ic.internal>
2010-09-01 11:14 ` [PATCH] ASoC: Add max98088 CODEC driver Mark Brown
2010-09-02 23:30 ` Peter Hsiang
2010-09-03 10:17 ` Mark Brown
2010-09-22 2:49 ` Peter Hsiang
2010-09-22 10:38 ` Mark Brown [this message]
2010-09-29 2:34 Peter Hsiang
2010-09-29 3:37 ` Mark Brown
2010-09-29 21:42 ` Peter Hsiang
2010-09-29 22:18 ` Mark Brown
2010-09-30 0:52 ` Peter Hsiang
2010-09-30 0:58 ` Mark Brown
2010-09-30 1:20 ` Peter Hsiang
2010-10-13 1:20 ` Peter Hsiang
2010-10-13 1:47 ` Joe Perches
2010-10-13 8:24 ` Mark Brown
2010-10-13 10:32 ` Mark Brown
2010-10-14 3:18 ` Peter Hsiang
2010-10-14 3:30 ` Peter Hsiang
2010-10-15 10:04 ` Liam Girdwood
2010-10-15 10:55 ` Mark Brown
2010-10-15 17:23 ` Peter Hsiang
-- strict thread matches above, loose matches on Subject: below --
2010-09-23 2:58 Peter Hsiang
2010-09-23 12:04 ` Mark Brown
2010-09-23 17:56 ` Peter Hsiang
2010-09-23 18:38 ` Mark Brown
2010-08-31 21:08 Peter Hsiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922103806.GC22361@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Jesse.Marroquin@maxim-ic.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=jy0922.shim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).