From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Return -1 instead of -EINVAL to ensure consistency
Date: Wed, 22 Sep 2010 16:49:05 +0100 [thread overview]
Message-ID: <20100922154905.GJ26395@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1285085047-31508-1-git-send-email-dp@opensource.wolfsonmicro.com>
On Tue, Sep 21, 2010 at 05:04:07PM +0100, Dimitris Papastamos wrote:
> The code can't really cope with I/O errors, so it would be better
> to be consistent throughout all cache functions and return -1 instead
> of -EINVAL.
>
> The return value of snd_soc_read(...) is mostly checked in the probe
> function and nowhere else.
Applied, thanks.
prev parent reply other threads:[~2010-09-22 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 16:04 [PATCH] ASoC: Return -1 instead of -EINVAL to ensure consistency Dimitris Papastamos
2010-09-22 8:54 ` Liam Girdwood
2010-09-22 15:49 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922154905.GJ26395@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox