From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver Date: Thu, 23 Sep 2010 13:04:43 +0100 Message-ID: <20100923120443.GF25663@rakim.wolfsonmicro.main> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id B49CE2414A for ; Thu, 23 Sep 2010 14:04:45 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Hsiang Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Peter Ujfalusi , "linux-kernel@vger.kernel.org" , Jesse Marroquin , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wed, Sep 22, 2010 at 07:58:48PM -0700, Peter Hsiang wrote: > This patch adds the MAX98088 CODEC driver. > Signed-off-by: Peter Hsiang When you submitted the driver on the 31st of August my first comment in the review was: | The major issue with this is that the driver needs to be updated to | current ASoC versions - you should always be working against the trees | that are in linux-next for new drivers. For ASoC you should be looking | at: | git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git Currently you should be looking at for-next or for-2.6.37, though the branch names will change as kernel development moves forward. This must be rectified before the driver can be considered for inclusion in the kernel. As things stand the code will not compile.