Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Jassi Brar <jassi.brar@samsung.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 3/3] ASoC: Clean up the CODEC device as well as the board for SMDK WM9713
Date: Fri, 24 Sep 2010 13:01:40 +0100	[thread overview]
Message-ID: <20100924120140.GL32112@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <AANLkTi=e0LK+1cD8x6iQv+GE3awrnO1yX585e6yxhrSF@mail.gmail.com>

On Fri, Sep 24, 2010 at 08:10:50PM +0900, Jassi Brar wrote:
> On Fri, Sep 24, 2010 at 6:22 PM, Mark Brown

> > Could you be more specific about what other changes you believe are
> > needed?

> IIUIC, the aim of this patch is to be able to reload the module, which isn't
> going to work simply with this chage - we need to do as well something
> about the 'soc-audio' platform device added the first time ?
> So IMHO, this change is a right step but not enough.

As I said in reply to your earlier mail the pre-existing code in the
driver already does that:

--- a/sound/soc/s3c24xx/smdk_wm9713.c
+++ b/sound/soc/s3c24xx/smdk_wm9713.c
@@ -95,6 +95,7 @@ err:
 static void __exit smdk_exit(void)
 {
        platform_device_unregister(smdk_snd_ac97_device);

This preexisting line from the context is cleaning up the soc-audio
device.

+       platform_device_unregister(smdk_snd_wm9713_device);

This new line cleans up the wm9713-codec device which is also added in
the probe function (yay AC'97!).

Reloading the module works, I've been doing that rather a lot.

  reply	other threads:[~2010-09-24 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23 14:40 [PATCH 1/3] ASoC: Remove unneeded WM9713 header include from SMDK WM9713 driver Mark Brown
2010-09-23 14:40 ` [PATCH 2/3] ASoC: Clarify naming for " Mark Brown
2010-09-23 14:45   ` Jassi Brar
2010-09-23 14:40 ` [PATCH 3/3] ASoC: Clean up the CODEC device as well as the board for SMDK WM9713 Mark Brown
2010-09-23 14:53   ` Jassi Brar
2010-09-23 14:56     ` Mark Brown
2010-09-24  0:27       ` Jassi Brar
2010-09-24  9:22         ` Mark Brown
2010-09-24 11:10           ` Jassi Brar
2010-09-24 12:01             ` Mark Brown [this message]
2010-09-24 15:18               ` Jassi Brar
2010-09-23 14:46 ` [PATCH 1/3] ASoC: Remove unneeded WM9713 header include from SMDK WM9713 driver Jassi Brar
2010-09-23 14:49   ` Mark Brown
2010-09-24  9:33 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924120140.GL32112@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jassi.brar@samsung.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox