From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: ASoC updates for 2.6.37 Date: Wed, 6 Oct 2010 08:19:33 -0700 Message-ID: <20101006151932.GB2803@opensource.wolfsonmicro.com> References: <20101006063401.GB17998@sirena.org.uk> <20101006073104.GC17998@sirena.org.uk> <1286357140.9697.17.camel@dplaptop> <1286372404.9697.22.camel@dplaptop> <1286374422.9697.28.camel@dplaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id A3C34244D2 for ; Wed, 6 Oct 2010 17:19:21 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Liam Girdwood , Barry Song List-Id: alsa-devel@alsa-project.org On Wed, Oct 06, 2010 at 04:24:18PM +0200, Takashi Iwai wrote: > Yeah, I don't say it's buggy. But it's wrong from a programming POV. > The proper endianess handling seems missing in the current code... I'll need to have a proper look and think but endianness handling for SPI is somewhat amusing - SPI is natually big endinan so controllers on little endian architectures do a byte swap to send, but only when they run in word oriented mode. If the word size is 8 bits they don't need to.