From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: tlv320dac33: Control for line output gain
Date: Wed, 13 Oct 2010 01:43:43 -0700 [thread overview]
Message-ID: <20101013084343.GA29239@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201010131140.26724.peter.ujfalusi@nokia.com>
On Wed, Oct 13, 2010 at 11:40:26AM +0300, Peter Ujfalusi wrote:
> In the documentation these gains are described like that (0.25V.V / 1V/V), and I
> wanted to use the same in the enum elements, but what about:
> /* L/R Line Output Gain */
> static const char *lr_lineout_gain_texts[] = {
> "Line -12dB DAC 0dB", "Line -6dB DAC 6dB",
> "Line 0dB DAC 12dB", "Line 6dB DAC 18dB",
> };
That's *much* clearer.
prev parent reply other threads:[~2010-10-13 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 8:08 [PATCH] ASoC: tlv320dac33: Control for line output gain Peter Ujfalusi
2010-10-13 8:14 ` Mark Brown
2010-10-13 8:40 ` Peter Ujfalusi
2010-10-13 8:43 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013084343.GA29239@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox