From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: alsa-devel@alsa-project.org, Saeed Bishara <saeed@marvell.com>,
Martin Michlmayr <tbm@cyrius.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [patch 1/3] ASoC: add support for alc562[123] codecs
Date: Wed, 13 Oct 2010 19:03:56 +0100 [thread overview]
Message-ID: <20101013180355.GA16978@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <871v7ux9ec.fsf@lechat.rtp-net.org>
On Wed, Oct 13, 2010 at 07:58:03PM +0200, Arnaud Patard wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> writes:
> >> + switch (level) {
> >> + case SND_SOC_BIAS_ON:
> >> + enable_power_depop(codec);
> >> + break;
> > enable_power_depop() takes a rather long time - about 500ms - which is
> > surprising for _ON. Are you sure it should be done here?
> It was there in the original driver and when working on this driver, I
> didn't see any reason for moving it elsewhere. tbh, if I have to move it
> elsewhere, I don't know where I'll put it.
Normally _PREPARE if you must do it whenever bringing up playback but
generally you should try to do anything really slow when bringing the
biases up to standby. Bear in mind that I've no idea what's actually
being done here...
next prev parent reply other threads:[~2010-10-13 18:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 9:44 [patch 0/3] ALC562[123] / t5325 sound support - try 2 Arnaud Patard
2010-10-12 9:44 ` [patch 1/3] ASoC: add support for alc562[123] codecs Arnaud Patard
2010-10-12 17:16 ` Mark Brown
2010-10-13 17:58 ` Arnaud Patard
2010-10-13 18:03 ` Mark Brown [this message]
2010-10-13 18:22 ` Arnaud Patard
2010-10-12 9:44 ` [patch 2/3] kirkwood: Add audio support to hp t5325 thin clients Arnaud Patard
2010-10-12 17:17 ` Mark Brown
2010-10-12 9:44 ` [patch 3/3] t5325: add audio support Arnaud Patard
2010-10-12 17:18 ` Mark Brown
2010-10-13 18:01 ` Arnaud Patard
2010-10-13 18:06 ` Mark Brown
2010-10-13 18:25 ` Arnaud Patard
2010-10-13 18:43 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-09-07 7:01 [patch 0/3] ASoC: t5325 " Arnaud Patard
2010-09-07 7:01 ` [patch 1/3] ASoC: add support for alc562[123] codecs Arnaud Patard
2010-09-07 10:21 ` Mark Brown
2010-09-07 13:23 ` Arnaud Patard
2010-09-08 10:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013180355.GA16978@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=lrg@slimlogic.co.uk \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).