From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alan Cox <alan@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>,
greg@kroah.com, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] sst: Intel SST audio driver
Date: Mon, 18 Oct 2010 17:16:11 -0700 [thread overview]
Message-ID: <20101019001611.GB27248@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20101018112418.505da748@linux.intel.com>
On Mon, Oct 18, 2010 at 11:24:18AM +0100, Alan Cox wrote:
> > Because it's not using the relevant framework at all, it's gone and
> > reinvented the wheel without a pressing reason to do so and this will
> > be very likely to create problems if the part is at all successful.
> Its more a case of predating the wheel as far as I can tell. In terms
ASoC has been in mainline since 2.6.21 which I imagine predates the
Moorestown code.
> of frameworks I don't think it matters as of itself - but once that
> means you have to write two different versions of the same codec chip
> driver for example yes it matters.
Yes, exactly - this is the big problem. It's often much worse than just
two different versions, with these things it's easy to end up having to
have versions per board.
> Putting it in staging allows that work to be done in public in a
> meaningful way where the code and changes get review.
I agree with the approach you're outlining here.
next prev parent reply other threads:[~2010-10-19 0:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 16:21 [PATCH] sst: Intel SST audio driver Alan Cox
2010-10-02 23:06 ` Mark Brown
[not found] ` <20101003112244.488282fd@linux.intel.com>
2010-10-03 20:30 ` Mark Brown
2010-10-04 9:04 ` Alan Cox
2010-10-04 23:49 ` Mark Brown
2010-10-17 9:02 ` Takashi Iwai
2010-10-17 10:36 ` Mark Brown
2010-10-17 11:14 ` Takashi Iwai
2010-10-17 16:18 ` Mark Brown
2010-10-17 21:36 ` Takashi Iwai
2010-10-17 22:11 ` Mark Brown
2010-10-18 6:14 ` Takashi Iwai
2010-10-18 7:20 ` Mark Brown
2010-10-18 7:49 ` Pavel Hofman
2010-10-18 8:10 ` Takashi Iwai
2010-10-18 10:34 ` Alan Cox
2010-10-18 13:19 ` Takashi Iwai
2010-10-18 11:07 ` Liam Girdwood
2010-10-18 10:24 ` Alan Cox
2010-10-19 0:16 ` Mark Brown [this message]
2010-10-05 15:48 ` Staging: sst: add " Greg KH
[not found] <mailman.1.1287309601.23450.alsa-devel@alsa-project.org>
2010-10-17 10:46 ` [PATCH] sst: " Koul, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019001611.GB27248@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=greg@kroah.com \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).