From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] wm1133-ev1: fix init for multimachine kernel
Date: Thu, 21 Oct 2010 14:58:40 -0700 [thread overview]
Message-ID: <20101021215840.GF30466@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1287696915-10392-1-git-send-email-eric@eukrea.com>
On Thu, Oct 21, 2010 at 11:35:15PM +0200, Eric Bénard wrote:
> + if (!machine_is_mx31ads())
> + /* return happy. We might run on a totally different machine */
> + return 0;
> +
This is not a sufficient check, we may be running on an mx31ads with a
different PMIC module.
next prev parent reply other threads:[~2010-10-21 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 21:35 [PATCH] wm1133-ev1: fix init for multimachine kernel Eric Bénard
2010-10-21 21:58 ` Mark Brown [this message]
2010-10-21 22:19 ` Eric Bénard
2010-10-22 1:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021215840.GF30466@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric@eukrea.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).