From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem Date: Wed, 3 Nov 2010 10:20:28 +0200 Message-ID: <20101103102028.8ff19cac.jhnikula@gmail.com> References: <201011021550.34885.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f51.google.com (mail-ew0-f51.google.com [209.85.215.51]) by alsa0.perex.cz (Postfix) with ESMTP id D413E10380C for ; Wed, 3 Nov 2010 09:20:21 +0100 (CET) Received: by ewy22 with SMTP id 22so119535ewy.38 for ; Wed, 03 Nov 2010 01:20:21 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Paul Walmsley Cc: alsa-devel@alsa-project.org, Janusz Krzysztofik , Mark Brown , Peter Ujfalusi , e3-hacking@earth.li, "linux-omap@vger.kernel.org" , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Tue, 2 Nov 2010 10:58:59 -0600 (MDT) Paul Walmsley wrote: > On Tue, 2 Nov 2010, Janusz Krzysztofik wrote: > > > In the new code introduced with commit cf4c87abe238ec17cd0255b4e21abd949d7f811e, > > "OMAP: McBSP: implement McBSP CLKR and FSR signal muxing via mach-omap2/mcbsp.c", > > the way omap1 build is supposed to bypass omap2 specific functionality doesn't > > optimize out all omap2 specific stuff. This breaks linking phase for omap1 > > machines, giving "undefined reference to `omap2_mcbsp1_mux_clkr_src'" > > and "undefined reference to `omap2_mcbsp1_mux_fsr_src'" errors. Fix it. > > > > Created and tested against linux-2.6.37-rc1. > > > > Signed-off-by: Janusz Krzysztofik > > Acked-by: Paul Walmsley > > Thanks Janusz. > Yep, this must go to 2.6.37. Acked-by: Jarkko Nikula