From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Push snd_soc_write() and snd_soc_read() into the source file
Date: Wed, 3 Nov 2010 12:30:35 -0400 [thread overview]
Message-ID: <20101103163032.GB16377@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1288792308.6871.3.camel@dplaptop>
On Wed, Nov 03, 2010 at 01:51:48PM +0000, Dimitris Papastamos wrote:
> On Mon, 2010-11-01 at 15:44 -0400, Mark Brown wrote:
> > +unsigned int snd_soc_write(struct snd_soc_codec *codec,
> > + unsigned int reg, unsigned int val)
> > +{
> > + dev_dbg(codec->dev, "write %x = %x\n", reg, val);
> > + return codec->driver->write(codec, reg, val);
> > +}
> > +EXPORT_SYMBOL_GPL(snd_soc_write);
> This sort of debugging output is already present in soc-cache.c. I
> guess it should be removed from soc-cache.c since it is duplicated
> across all different write() I/O types.
That's the idea; this is much fewer lines of code and also covers all
the MFDs and whatnot that can't use the soc-cache code for whatever
reasons.
prev parent reply other threads:[~2010-11-03 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 19:44 [PATCH] ASoC: Push snd_soc_write() and snd_soc_read() into the source file Mark Brown
2010-11-03 13:51 ` Dimitris Papastamos
2010-11-03 16:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103163032.GB16377@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).