From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/4] ASoC: soc.h: Add new caching API prototypes and hooks
Date: Thu, 4 Nov 2010 14:20:19 -0400 [thread overview]
Message-ID: <20101104182019.GC6088@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1288880564-31957-2-git-send-email-dp@opensource.wolfsonmicro.com>
On Thu, Nov 04, 2010 at 02:22:41PM +0000, Dimitris Papastamos wrote:
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
As previously mentioned please split this series up into patches which
individually add some useful functiionality
> +/* SoC cache ops */
> +struct snd_soc_cache_ops {
> + int id; /* corresponds to snd_soc_compress_type */
Shouldn't this be using the enum then?
> --- a/sound/soc/Kconfig
> +++ b/sound/soc/Kconfig
> @@ -4,6 +4,8 @@
>
> menuconfig SND_SOC
> tristate "ALSA for SoC audio support"
> + select LZO_COMPRESS
> + select LZO_DECOMPRESS
> select SND_PCM
> select AC97_BUS if SND_SOC_AC97_BUS
> select SND_JACK if INPUT=y || INPUT=SND
This definitely looks like it should be in a separate patch.
next prev parent reply other threads:[~2010-11-04 18:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 14:22 [PATCH 0/4] ASoC: Introduce the new caching API Dimitris Papastamos
2010-11-04 14:22 ` [PATCH 1/4] ASoC: soc.h: Add new caching API prototypes and hooks Dimitris Papastamos
2010-11-04 18:20 ` Mark Brown [this message]
2010-11-04 14:22 ` [PATCH 2/4] ASoC: soc-cache: Add support for flat register caching Dimitris Papastamos
2010-11-04 18:31 ` Mark Brown
2010-11-05 9:34 ` Dimitris Papastamos
2010-11-05 13:31 ` Mark Brown
2010-11-05 13:59 ` Dimitris Papastamos
2010-11-05 14:07 ` Mark Brown
2010-11-05 14:12 ` Dimitris Papastamos
2010-11-05 15:25 ` Mark Brown
2010-11-05 11:45 ` Dimitris Papastamos
2010-11-04 14:22 ` [PATCH 3/4] ASoC: soc-cache: Add support for LZO " Dimitris Papastamos
2010-11-04 22:45 ` Mark Brown
2010-11-05 10:22 ` Dimitris Papastamos
2010-11-05 13:33 ` Mark Brown
2010-11-04 14:22 ` [PATCH 4/4] ASoC: soc-cache: Add support for rbtree based " Dimitris Papastamos
2010-11-04 18:49 ` Mark Brown
2010-11-04 18:50 ` Mark Brown
2010-11-05 9:38 ` Dimitris Papastamos
-- strict thread matches above, loose matches on Subject: below --
2010-10-22 14:28 [PATCH 0/4] ASoC: Implement new caching API Dimitris Papastamos
2010-10-22 14:28 ` [PATCH 1/4] ASoC: soc.h: Add new caching API prototypes and hooks Dimitris Papastamos
2010-10-22 15:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104182019.GC6088@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).