From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 3/4] ASoC: soc-cache: Add support for LZO register caching
Date: Thu, 4 Nov 2010 18:45:58 -0400 [thread overview]
Message-ID: <20101104224557.GC8161@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1288880564-31957-4-git-send-email-dp@opensource.wolfsonmicro.com>
On Thu, Nov 04, 2010 at 02:22:43PM +0000, Dimitris Papastamos wrote:
This looks really good except for the handling of unsupported register
sizes I mentioend for another patch and the fact that the LZO additions
to Kconfig probably ought to go in here.
> by using the LZO compression technique, one can get down to ~3-5kB. There
> might be a performance penalty associated with each individual read/write
> due to decompressing/compressing the underlying cache, however that should not
I strongly suspect that there will actually be a performance penalty
associated with the (de-)compress :)
As we discussed previously this can be mitigated against in future by
keeping the last accessed block of memory uncompressed so that we don't
need to do the LZO operations so often when doing a sequence of accesses
to the same area of the register map (this should work well during DAPM
runs since the power bits tend to all be close together, for example).
Timeouts or a different chunking algorithm could be used to reduce the
memory cost of this, though we need to be careful we don't overengineer.
> be noticeable. The memory benefits depend on whether the target architecture
> can get rid of the memory occupied by the original register defaults cache
> which is marked as __devinitconst.
Even if it doesn't manage to get rid of the original copy there will of
course still be some memory gain as the runtime allocated register cache
will be compressed - only the size of the win will be affected, there's
no question that there will be some benefit unless the register map is
pathologic and doesn't compress.
next prev parent reply other threads:[~2010-11-04 22:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 14:22 [PATCH 0/4] ASoC: Introduce the new caching API Dimitris Papastamos
2010-11-04 14:22 ` [PATCH 1/4] ASoC: soc.h: Add new caching API prototypes and hooks Dimitris Papastamos
2010-11-04 18:20 ` Mark Brown
2010-11-04 14:22 ` [PATCH 2/4] ASoC: soc-cache: Add support for flat register caching Dimitris Papastamos
2010-11-04 18:31 ` Mark Brown
2010-11-05 9:34 ` Dimitris Papastamos
2010-11-05 13:31 ` Mark Brown
2010-11-05 13:59 ` Dimitris Papastamos
2010-11-05 14:07 ` Mark Brown
2010-11-05 14:12 ` Dimitris Papastamos
2010-11-05 15:25 ` Mark Brown
2010-11-05 11:45 ` Dimitris Papastamos
2010-11-04 14:22 ` [PATCH 3/4] ASoC: soc-cache: Add support for LZO " Dimitris Papastamos
2010-11-04 22:45 ` Mark Brown [this message]
2010-11-05 10:22 ` Dimitris Papastamos
2010-11-05 13:33 ` Mark Brown
2010-11-04 14:22 ` [PATCH 4/4] ASoC: soc-cache: Add support for rbtree based " Dimitris Papastamos
2010-11-04 18:49 ` Mark Brown
2010-11-04 18:50 ` Mark Brown
2010-11-05 9:38 ` Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104224557.GC8161@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).