From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/7] ASoC: i.MX31ads: initialize only on correct machine
Date: Fri, 5 Nov 2010 09:09:42 -0400 [thread overview]
Message-ID: <20101105130941.GA13709@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20101105091624.GS6017@pengutronix.de>
On Fri, Nov 05, 2010 at 10:16:24AM +0100, Sascha Hauer wrote:
> On Thu, Nov 04, 2010 at 02:51:36PM -0400, Mark Brown wrote:
> > As previously discussed we need a better check than this - most of these
> > machines won't have a 1133-EV1 PMIC module on them. Better to convert
> > the driver to instantiate from a platform device...
> This does not solve the problem as we do not know when to register the
> platform_device. I think what we need is a kernel parameter which can be
> used to select the correct path in arch/arm/mach-mx3/mach-mx31ads.c
It can be registered in the callback that's called immmediately after
the WM835x is probed on the machine driver.
> aswell. I will look into it. For now, can we just take this patch? It
> at least fixes all other i.MX31 boards and leaves only the mx31ads to
> work on.
I'd much rather get it fixed properly - it's not so urgent since it
really only only affects allyesconfig or allmodconfig type stuff with
people explicitly loading the driver.
next prev parent reply other threads:[~2010-11-05 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 16:05 [PATCH for -rc] i.MX updates Sascha Hauer
2010-11-04 16:05 ` [PATCH 1/7] ASoC: i.MX31ads: initialize only on correct machine Sascha Hauer
2010-11-04 18:51 ` Mark Brown
2010-11-05 9:16 ` Sascha Hauer
2010-11-05 13:09 ` Mark Brown [this message]
2010-11-04 16:05 ` [PATCH 2/7] ASoC i.MX eukrea tlv320: Fix for multicomponent Sascha Hauer
2010-11-04 16:05 ` [PATCH 3/7] ASoC i.MX phycore ac97: remove unnecessary includes Sascha Hauer
2010-11-04 16:05 ` [PATCH 4/7] ASoC i.MX: register dma audio device Sascha Hauer
2010-11-04 16:05 ` [PATCH 5/7] ASoC i.MX: switch to new DMA api Sascha Hauer
2010-11-04 16:05 ` [PATCH 6/7] phycore-ac97: add ac97 to cardname Sascha Hauer
2010-11-04 16:05 ` [PATCH 7/7] ASoC: i.MX: we can do mono Sascha Hauer
2010-11-05 8:28 ` [PATCH for -rc] i.MX updates Liam Girdwood
2010-11-05 13:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101105130941.GA13709@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).