* [PATCH] Fix Atmel soc audio boards Kconfig dependency
@ 2010-11-10 20:02 Ryan Mallon
2010-11-10 21:04 ` Liam Girdwood
2010-11-11 14:57 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Ryan Mallon @ 2010-11-10 20:02 UTC (permalink / raw)
To: alsa-devel@alsa-project.org
Cc: Sedji Gaouaou, Mark Brown, gwossum, Liam Girdwood
Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
clk_set_parent and clk_set_rate when building without
AT91_PROGRAMMABLE_CLOCKS.
Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
---
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index e720d5e..bee3c94 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -16,7 +16,8 @@ config SND_ATMEL_SOC_SSC
config SND_AT91_SOC_SAM9G20_WM8731
tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation board"
- depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC
+ depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC && \
+ AT91_PROGRAMMABLE_CLOCKS
select SND_ATMEL_SOC_SSC
select SND_SOC_WM8731
help
@@ -25,7 +26,7 @@ config SND_AT91_SOC_SAM9G20_WM8731
config SND_AT32_SOC_PLAYPAQ
tristate "SoC Audio support for PlayPaq with WM8510"
- depends on SND_ATMEL_SOC && BOARD_PLAYPAQ
+ depends on SND_ATMEL_SOC && BOARD_PLAYPAQ && AT91_PROGRAMMABLE_CLOCKS
select SND_ATMEL_SOC_SSC
select SND_SOC_WM8510
help
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix Atmel soc audio boards Kconfig dependency
2010-11-10 20:02 [PATCH] Fix Atmel soc audio boards Kconfig dependency Ryan Mallon
@ 2010-11-10 21:04 ` Liam Girdwood
2010-11-10 21:54 ` Ryan Mallon
2010-11-11 14:57 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Liam Girdwood @ 2010-11-10 21:04 UTC (permalink / raw)
To: Ryan Mallon
Cc: gwossum, Gaouaou, alsa-devel@alsa-project.org, Mark Brown, Sedji
On Thu, 2010-11-11 at 09:02 +1300, Ryan Mallon wrote:
> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
> clk_set_parent and clk_set_rate when building without
> AT91_PROGRAMMABLE_CLOCKS.
>
> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix Atmel soc audio boards Kconfig dependency
2010-11-10 21:04 ` Liam Girdwood
@ 2010-11-10 21:54 ` Ryan Mallon
2010-11-10 23:09 ` Geoffrey Wossum
0 siblings, 1 reply; 6+ messages in thread
From: Ryan Mallon @ 2010-11-10 21:54 UTC (permalink / raw)
To: Liam Girdwood
Cc: Sedji Gaouaou, alsa-devel@alsa-project.org, Mark Brown, gwossum
On 11/11/2010 10:04 AM, Liam Girdwood wrote:
> On Thu, 2010-11-11 at 09:02 +1300, Ryan Mallon wrote:
>
>> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
>> audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
>> clk_set_parent and clk_set_rate when building without
>> AT91_PROGRAMMABLE_CLOCKS.
>>
>> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
>>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
Just realised that the PlayPaq board only appears in the sound/soc/atmel
directory. I cannot find a board file for it under either
arch/arm/mach-at91 or arch/avr32/. The updated patch below only changes
the dependency for the SAM9G20-EK board since I think the PlayPaq is
actually AVR32, and therefore should not depend on
AT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.
---
Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
audio SAM9G20-EK board. Fixes link errors on missing clk_set_parent and
clk_set_rate when building without AT91_PROGRAMMABLE_CLOCKS.
Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
---
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index e720d5e..a614181 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -16,7 +16,8 @@ config SND_ATMEL_SOC_SSC
config SND_AT91_SOC_SAM9G20_WM8731
tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation board"
- depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC
+ depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC && \
+ AT91_PROGRAMMABLE_CLOCKS
select SND_ATMEL_SOC_SSC
select SND_SOC_WM8731
help
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix Atmel soc audio boards Kconfig dependency
2010-11-10 21:54 ` Ryan Mallon
@ 2010-11-10 23:09 ` Geoffrey Wossum
2010-11-11 11:42 ` Liam Girdwood
0 siblings, 1 reply; 6+ messages in thread
From: Geoffrey Wossum @ 2010-11-10 23:09 UTC (permalink / raw)
To: Ryan Mallon
Cc: Sedji Gaouaou, alsa-devel@alsa-project.org, Mark Brown,
gwossum@acm.org, Liam Girdwood
On Wednesday 10 November 2010 3:54:08 pm Ryan Mallon wrote:
> On 11/11/2010 10:04 AM, Liam Girdwood wrote:
> > On Thu, 2010-11-11 at 09:02 +1300, Ryan Mallon wrote:
> >> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> >> audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
> >> clk_set_parent and clk_set_rate when building without
> >> AT91_PROGRAMMABLE_CLOCKS.
> >>
> >> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
> >
> > Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
> Just realised that the PlayPaq board only appears in the sound/soc/atmel
> directory. I cannot find a board file for it under either
> arch/arm/mach-at91 or arch/avr32/. The updated patch below only changes
> the dependency for the SAM9G20-EK board since I think the PlayPaq is
> actually AVR32, and therefore should not depend on
> AT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.
PlayPaq is an AT32AP7000 board, so the new patch is correct.
> ---
> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> audio SAM9G20-EK board. Fixes link errors on missing clk_set_parent and
> clk_set_rate when building without AT91_PROGRAMMABLE_CLOCKS.
>
> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
Acked-by: Geoffrey Wossum <gwossum@acm.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix Atmel soc audio boards Kconfig dependency
2010-11-10 23:09 ` Geoffrey Wossum
@ 2010-11-11 11:42 ` Liam Girdwood
0 siblings, 0 replies; 6+ messages in thread
From: Liam Girdwood @ 2010-11-11 11:42 UTC (permalink / raw)
To: Geoffrey Wossum
Cc: gwossum@acm.org, Sedji Gaouaou, Ryan Mallon, Mark Brown,
alsa-devel@alsa-project.org
On Wed, 2010-11-10 at 17:09 -0600, Geoffrey Wossum wrote:
> On Wednesday 10 November 2010 3:54:08 pm Ryan Mallon wrote:
> > On 11/11/2010 10:04 AM, Liam Girdwood wrote:
> > > On Thu, 2010-11-11 at 09:02 +1300, Ryan Mallon wrote:
> > >> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> > >> audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
> > >> clk_set_parent and clk_set_rate when building without
> > >> AT91_PROGRAMMABLE_CLOCKS.
> > >>
> > >> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
> > >
> > > Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
> >
> > Just realised that the PlayPaq board only appears in the sound/soc/atmel
> > directory. I cannot find a board file for it under either
> > arch/arm/mach-at91 or arch/avr32/. The updated patch below only changes
> > the dependency for the SAM9G20-EK board since I think the PlayPaq is
> > actually AVR32, and therefore should not depend on
> > AT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.
>
> PlayPaq is an AT32AP7000 board, so the new patch is correct.
>
> > ---
> > Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> > audio SAM9G20-EK board. Fixes link errors on missing clk_set_parent and
> > clk_set_rate when building without AT91_PROGRAMMABLE_CLOCKS.
> >
> > Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
>
> Acked-by: Geoffrey Wossum <gwossum@acm.org>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix Atmel soc audio boards Kconfig dependency
2010-11-10 20:02 [PATCH] Fix Atmel soc audio boards Kconfig dependency Ryan Mallon
2010-11-10 21:04 ` Liam Girdwood
@ 2010-11-11 14:57 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-11-11 14:57 UTC (permalink / raw)
To: Ryan Mallon
Cc: Sedji Gaouaou, alsa-devel@alsa-project.org, gwossum,
Liam Girdwood
On Thu, Nov 11, 2010 at 09:02:30AM +1300, Ryan Mallon wrote:
> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
> clk_set_parent and clk_set_rate when building without
> AT91_PROGRAMMABLE_CLOCKS.
>
> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-11-11 14:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-10 20:02 [PATCH] Fix Atmel soc audio boards Kconfig dependency Ryan Mallon
2010-11-10 21:04 ` Liam Girdwood
2010-11-10 21:54 ` Ryan Mallon
2010-11-10 23:09 ` Geoffrey Wossum
2010-11-11 11:42 ` Liam Girdwood
2010-11-11 14:57 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).