From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCHv2 3/3] ASoC: Extend DAPM to handle power changes on cross-device paths
Date: Fri, 12 Nov 2010 15:13:32 +0000 [thread overview]
Message-ID: <20101112151332.GF17283@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1289553806-28625-4-git-send-email-jhnikula@gmail.com>
On Fri, Nov 12, 2010 at 11:23:26AM +0200, Jarkko Nikula wrote:
> list_for_each_entry_safe(w, n, list, power_list) {
> ret = 0;
>
> /* Do we need to apply any queued changes? */
> - if (sort[w->id] != cur_sort || w->reg != cur_reg) {
> + if (sort[w->id] != cur_sort || w->reg != cur_reg ||
> + w->dapm != cur_dapm) {
> if (!list_empty(&pending))
> - dapm_seq_run_coalesced(dapm, &pending);
> + dapm_seq_run_coalesced(cur_dapm, &pending);
>
> INIT_LIST_HEAD(&pending);
> cur_sort = -1;
> cur_reg = SND_SOC_NOPM;
We need a corresponding change in dapm_seq_compare() to ensure that the
widgets for a given card are grouped together. I'll send out some
patches to do that shortly since I just noticed there's an oversight
there anyway.
next prev parent reply other threads:[~2010-11-12 15:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 9:23 [PATCHv2 0/3] ASoC: Extend DAPM to handle cross-device paths Jarkko Nikula
2010-11-12 9:23 ` [PATCHv2 1/3] ASoC: Move DAPM paths from DAPM context to snd_soc_card Jarkko Nikula
2010-11-12 9:23 ` [PATCHv2 2/3] ASoC: Move widgets " Jarkko Nikula
2010-11-12 13:18 ` Mark Brown
2010-11-12 13:57 ` Jarkko Nikula
2010-11-12 14:25 ` Jarkko Nikula
2010-11-12 14:40 ` Mark Brown
2010-11-12 9:23 ` [PATCHv2 3/3] ASoC: Extend DAPM to handle power changes on cross-device paths Jarkko Nikula
2010-11-12 15:13 ` Mark Brown [this message]
2010-11-12 13:51 ` [PATCHv2 0/3] ASoC: Extend DAPM to handle " Mark Brown
2010-11-12 13:54 ` Mark Brown
2010-11-12 14:15 ` Jarkko Nikula
2010-11-12 14:32 ` Mark Brown
2010-11-12 14:07 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112151332.GF17283@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).