From: Jarkko Nikula <jhnikula@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ASoC: Use DAPM context rather than CODEC when constructing sequences
Date: Fri, 12 Nov 2010 21:06:43 +0200 [thread overview]
Message-ID: <20101112210643.bb39d54a.jhnikula@gmail.com> (raw)
In-Reply-To: <1289577671-13837-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On Fri, 12 Nov 2010 16:01:11 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> DAPM widgets may be associated with non-CODEC devices so compare based
> on the DAPM context rather than the CODEC pointer.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-dapm.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index bc2ec06..5ee93a5 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -710,8 +710,8 @@ static int dapm_seq_compare(struct snd_soc_dapm_widget *a,
> return sort[a->id] - sort[b->id];
> if (a->reg != b->reg)
> return a->reg - b->reg;
> - if (a->codec != b->codec)
> - return (unsigned long)a->codec - (unsigned long)b->codec;
> + if (a->dapm != b->dapm)
> + return (unsigned long)a->dapm - (unsigned long)b->dapm;
>
Definitely, this conversion was missing from DAPM decoupling patch.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2010-11-12 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 16:01 [PATCH 2.6.37 1/2] ASoC: Fix dapm_seq_compare() for multi-component Mark Brown
2010-11-12 16:01 ` [PATCH 2/2] ASoC: Use DAPM context rather than CODEC when constructing sequences Mark Brown
2010-11-12 19:06 ` Jarkko Nikula [this message]
2010-11-15 13:10 ` Liam Girdwood
2010-11-12 19:06 ` [PATCH 2.6.37 1/2] ASoC: Fix dapm_seq_compare() for multi-component Jarkko Nikula
2010-11-12 19:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112210643.bb39d54a.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).