From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Rosin <peda@lysator.liu.se>
Cc: alsa-devel@alsa-project.org,
Hans-Christian Egtvedt <hcegtvedt@atmel.com>,
Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>,
Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH] ALSA: AT73C213: Rectify misleading comments.
Date: Mon, 15 Nov 2010 19:16:42 +0000 [thread overview]
Message-ID: <20101115191642.GG3338@sirena.org.uk> (raw)
In-Reply-To: <4CE1816F.6080000@lysator.liu.se>
On Mon, Nov 15, 2010 at 07:52:31PM +0100, Peter Rosin wrote:
> Den 2010-11-15 15:50 skrev Hans-Christian Egtvedt:
> > IIRC the bitrate is controlled by a generic clock, and it has a power of
> > two divider possibility. Hence the comment about power of two.
> My point is that the "ssc_div must be a power of 2" comment is
> misleading in that this is an external (to the driver) constraint that
> has nothing to do with the driver code. This constraint is also not
> universally true, and the comment just makes it harder to follow what
> the driver code is doing.
This code probably ought to be converted to ASoC anyway :)
prev parent reply other threads:[~2010-11-15 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 11:29 [PATCH] ALSA: AT73C213: Rectify misleading comments Peter Rosin
2010-11-15 14:50 ` Hans-Christian Egtvedt
2010-11-15 18:52 ` Peter Rosin
2010-11-15 19:16 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115191642.GG3338@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=hans-christian.egtvedt@atmel.com \
--cc=hcegtvedt@atmel.com \
--cc=peda@axentia.se \
--cc=peda@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox