From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jesse Marroquin <jesse.marroquin@maxim-ic.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Hsiang <Peter.Hsiang@maxim-ic.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Add support for MAX98089 CODEC
Date: Thu, 18 Nov 2010 11:07:31 +0000 [thread overview]
Message-ID: <20101118110731.GC7233@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4CE43A80.4050209@maxim-ic.com>
On Wed, Nov 17, 2010 at 02:26:40PM -0600, Jesse Marroquin wrote:
> This patch adds initial support for the MAX98089 CODEC.
Applied, thanks. One thing:
> struct max98088_priv {
> u8 reg_cache[M98088_REG_CNT];
> + enum max98088_type devtype;
You currently never actually read the devtype anywhere - if the devices
really are fully register compatible (eg, if the differences are in
physical or electrical characteristics which aren't visible to software)
then there's no need to bother doing this, though equally well it does
no harm.
next prev parent reply other threads:[~2010-11-18 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4CE43A80.4050209@maxim-ic.com>
2010-11-17 22:29 ` [PATCH] ASoC: Add support for MAX98089 CODEC Liam Girdwood
2010-11-18 11:07 ` Mark Brown [this message]
2010-11-17 20:26 Jesse Marroquin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118110731.GC7233@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=jesse.marroquin@maxim-ic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).