From: Jarkko Nikula <jhnikula@gmail.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
tony@atomide.com, alsa-devel@alsa-project.org,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
e3-hacking@earth.li
Subject: Re: [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem
Date: Tue, 23 Nov 2010 09:26:30 +0200 [thread overview]
Message-ID: <20101123092630.7267a7ab.jhnikula@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1011221745490.20215@utopia.booyaka.com>
On Mon, 22 Nov 2010 17:48:24 -0700 (MST)
Paul Walmsley <paul@pwsan.com> wrote:
> > Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
>
> Thanks for fixing this. What do you think about the following patch
> instead? It should avoid any compiler issues.
>
Hmm.. looks like Janusz's patch is still in Liam's for-2.6.37
branch only.
> +/*
> + * The following functions are only required on an OMAP1-only build.
> + * mach-omap2/mcbsp.c contains the real functions
> + */
> +#ifndef CONFIG_ARCH_OMAP2PLUS
> +int omap2_mcbsp_set_clks_src(u8 id, u8 fck_src_id)
> +{
Would that create a new problem if we are able to compile some day
omap1 and omap2 support into same kernel? I agree with you that passing
these via platform_data sounds the right solution.
--
Jarkko
next prev parent reply other threads:[~2010-11-23 7:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 14:50 [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem Janusz Krzysztofik
2010-11-02 14:56 ` Mark Brown
2010-11-02 16:58 ` Paul Walmsley
2010-11-03 8:20 ` Jarkko Nikula
2010-11-03 14:16 ` [alsa-devel] " Liam Girdwood
2010-11-23 0:48 ` Paul Walmsley
2010-11-23 7:26 ` Jarkko Nikula [this message]
2010-11-23 10:32 ` [alsa-devel] " Liam Girdwood
2010-11-24 23:35 ` Tony Lindgren
2010-11-24 23:53 ` Tony Lindgren
2010-11-25 7:02 ` Jarkko Nikula
2010-11-25 12:47 ` Janusz Krzysztofik
2010-11-25 17:45 ` Paul Walmsley
2010-11-23 0:50 ` Paul Walmsley
[not found] ` <alpine.DEB.2.00.1011221748410.20215@utopia.booyaka.com>
2010-11-23 7:38 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123092630.7267a7ab.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=e3-hacking@earth.li \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).