Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Harsha, Priya" <priya.harsha@intel.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: usage of SOC_ENUM_SINGLE
Date: Fri, 26 Nov 2010 14:51:48 +0000	[thread overview]
Message-ID: <20101126145147.GJ30360@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <438BB0150E931F4B9CE701519A44630104BED4868C@bgsmsx502.gar.corp.intel.com>

On Fri, Nov 26, 2010 at 08:15:11PM +0530, Koul, Vinod wrote:

> So this should do, right?

> SOC_VALUE_ENUM_SINGLE(MSIC_OUTEN, 0, 0x43,
> 		ARRAY_SIZE(headset_switch_text),
> 		headset_switch_text, headset_switch_values)

> With, static const char *headset_switch_values[] = {
> 	"0x40", "0x03"
> };

No, that's not going to work and I'd be astonished if it compiled
cleanly.  You need to pass the *values* you want to set - look at the
uses of this in exiting CODEC drivers for examples of how to use this.

      reply	other threads:[~2010-11-26 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-26 10:18 usage of SOC_ENUM_SINGLE Koul, Vinod
2010-11-26 11:52 ` Mark Brown
2010-11-26 14:45   ` Koul, Vinod
2010-11-26 14:51     ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101126145147.GJ30360@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=priya.harsha@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox