From: Jarkko Nikula <jhnikula@gmail.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 3/3] ASoC: soc-core: Generalize snd_soc_prefix_map and rename to snd_soc_codec_conf
Date: Thu, 2 Dec 2010 17:26:27 +0200 [thread overview]
Message-ID: <20101202172627.556b88a5.jhnikula@gmail.com> (raw)
In-Reply-To: <1291301583-15491-4-git-send-email-dp@opensource.wolfsonmicro.com>
On Thu, 2 Dec 2010 14:53:03 +0000
Dimitris Papastamos <dp@opensource.wolfsonmicro.com> wrote:
> The snd_soc_codec_conf struct now holds codec specific configuration
> information.
>
> A new configuration option has been added to allow machine drivers to
> override the compression type set by the codec driver.
>
> In the absence of providing an snd_soc_codec_conf struct or when providing
> one but not setting the compress_type member to anything, the one supplied
> by the codec driver will be used instead. In all other cases the one
> set in the snd_soc_codec_conf struct takes effect.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
> include/sound/soc.h | 22 +++++++++++++++-------
> sound/soc/soc-core.c | 6 +++---
> 2 files changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/include/sound/soc.h b/include/sound/soc.h
> index a26cdf9..4409e97 100644
> --- a/include/sound/soc.h
> +++ b/include/sound/soc.h
> @@ -579,9 +579,20 @@ struct snd_soc_dai_link {
> struct snd_soc_ops *ops;
> };
>
> -struct snd_soc_prefix_map {
> +struct snd_soc_codec_conf {
> const char *dev_name;
No any objections from my side. Good to generalize this struct.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2010-12-02 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 14:53 [PATCH 0/3] ASoC: Laying the groundwork for compress_type overriding Dimitris Papastamos
2010-12-02 14:53 ` [PATCH 1/3] ASoC: Add compress_type as a member to snd_soc_codec Dimitris Papastamos
2010-12-02 14:53 ` [PATCH 2/3] ASoC: Change the base value of compress_type Dimitris Papastamos
2010-12-02 14:53 ` [PATCH 3/3] ASoC: soc-core: Generalize snd_soc_prefix_map and rename to snd_soc_codec_conf Dimitris Papastamos
2010-12-02 15:26 ` Jarkko Nikula [this message]
2010-12-03 16:15 ` [PATCH 0/3] ASoC: Laying the groundwork for compress_type overriding Liam Girdwood
2010-12-03 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202172627.556b88a5.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox