From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Seungwhan Youn <sw.youn@samsung.com>
Cc: alsa-devel@alsa-project.org, jassi.brar@samsung.com, lrg@slimlogic.co.uk
Subject: Re: [PATCH 3/3] ASoC: SAMSUNG: Match spdif source clock id and asoc platform device
Date: Fri, 3 Dec 2010 11:44:17 +0000 [thread overview]
Message-ID: <20101203114416.GG3182@sirena.org.uk> (raw)
In-Reply-To: <1291369067-31429-1-git-send-email-sw.youn@samsung.com>
On Fri, Dec 03, 2010 at 06:37:47PM +0900, Seungwhan Youn wrote:
> This patch modify to match ids between source clock id and asoc platform
> device that spdif driver can find sclk_audio0 with device id.
Something's seriously wrong if you need to do this...
> - smdk_snd_spdif_device = platform_device_alloc("soc-audio", -1);
> + smdk_snd_spdif_device = platform_device_alloc("soc-audio", 0);
...the soc-audio device is a virtual device so should have no clocks
associated with it. The driver should not be using the platform device
as an argument for clk_get() in the first place.
next prev parent reply other threads:[~2010-12-03 11:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 9:27 [PATCH 1/3] ASoC: SAMSUNG: Fix initial return value Seungwhan Youn
2010-12-03 9:32 ` [PATCH 2/3] ASoC: SAMSUNG: Remove duplicated snd_card on smdk_spdif Seungwhan Youn
2010-12-03 10:05 ` Jassi Brar
2010-12-03 9:37 ` [PATCH 3/3] ASoC: SAMSUNG: Match spdif source clock id and asoc platform device Seungwhan Youn
2010-12-03 10:06 ` Jassi Brar
2010-12-03 10:17 ` Seungwhan Youn
2010-12-03 10:23 ` Jassi Brar
2010-12-03 10:33 ` Jassi Brar
2010-12-03 10:48 ` Seungwhan Youn
2010-12-03 11:44 ` Mark Brown [this message]
2010-12-04 5:15 ` Seungwhan Youn
2010-12-04 15:40 ` Jassi Brar
2010-12-06 12:46 ` Mark Brown
2010-12-07 2:10 ` Jassi Brar
2010-12-07 11:19 ` Mark Brown
2010-12-03 9:45 ` [PATCH 1/3] ASoC: SAMSUNG: Fix initial return value Jassi Brar
2010-12-03 16:42 ` Mark Brown
2010-12-04 0:07 ` Seungwhan Youn
2010-12-08 1:00 ` Seungwhan Youn
2010-12-08 10:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203114416.GG3182@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jassi.brar@samsung.com \
--cc=lrg@slimlogic.co.uk \
--cc=sw.youn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox