From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [RFC v2 0/3] ASoC: Option to reorder widget power sequence
Date: Tue, 7 Dec 2010 10:51:50 +0000 [thread overview]
Message-ID: <20101207105150.GA4698@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <201012071129.15475.peter.ujfalusi@nokia.com>
On Tue, Dec 07, 2010 at 11:29:15AM +0200, Peter Ujfalusi wrote:
> Fair enough.
> I did taken a look at the possibility to do the register update between DAPM
> power down and up, but I thought it is a bit big change (the place, where the
> DAPM power down and up happens is quite deep, and I was not sure how to inject
> things between those).
Stash the callback in the DAPM context - we have to lock the context to
do the path walks anyway so no issue with reentrancy.
> If we do the update at the same time (or around), when the power for the
> switch would have been enabled, than we are filtering the switching for the
> DAPM widgets before the switch.
On the other hand it's possible that this will result in a sharp switch
in of a DC offset rather than a slow ramp, and anything doing DC offset
correction is going to want its input to be up before correcting.
prev parent reply other threads:[~2010-12-07 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 13:31 [RFC v2 0/3] ASoC: Option to reorder widget power sequence Peter Ujfalusi
2010-12-03 13:31 ` [RFC v2 1/3] ASoC: core: DAPM widget flag for reversed power up sequence Peter Ujfalusi
2010-12-03 13:31 ` [RFC v2 2/3] ASoC: core: Helper function to request reversed widget power up Peter Ujfalusi
2010-12-03 13:31 ` [RFC v2 3/3] ASoC: tlv320dac33: Reverse the power up sequence for bypass switches Peter Ujfalusi
2010-12-06 22:40 ` [RFC v2 0/3] ASoC: Option to reorder widget power sequence Mark Brown
2010-12-07 9:29 ` Peter Ujfalusi
2010-12-07 10:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207105150.GA4698@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox