From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: "ext Olaya, Margarita" <magi.olaya@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: mcbsp: Add McBSP support for OMAP4
Date: Tue, 7 Dec 2010 10:52:55 +0200 [thread overview]
Message-ID: <201012071052.56009.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1889FA7136B567478A67D4B0F85B0CCEA4C52E7F@dlee06.ent.ti.com>
On Tuesday 07 December 2010 00:34:40 ext Olaya, Margarita wrote:
> @@ -623,6 +652,9 @@ static int omap_mcbsp_dai_set_dai_sysclk(struct
> snd_soc_dai *cpu_dai, if (cpu_class_is_omap1()) {
> err = -EINVAL;
> break;
> + } else if (cpu_is_omap44xx()) {
> + regs->srgr2 |= CLKSM;
> + break;
Are you sure about this?
You want to select FCLK as functional clock...
So I think you want to have the source from CLKS, and CLKS should have the
FCLK selected, so I think you want:
~CLKSM in srgr2, and ~CLKME in pcr0
> }
> err = omap2_mcbsp_set_clks_src(mcbsp_data->bus_id,
> MCBSP_CLKS_PRCM_SRC);
--
Péter
next prev parent reply other threads:[~2010-12-07 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:34 [PATCH] ASoC: mcbsp: Add McBSP support for OMAP4 Olaya, Margarita
2010-12-06 22:44 ` Mark Brown
2010-12-07 8:52 ` Peter Ujfalusi [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-20 17:32 Olaya, Margarita
2010-12-20 17:36 ` Mark Brown
2010-12-21 9:48 ` Jarkko Nikula
2010-12-21 10:17 ` Liam Girdwood
2010-12-23 6:42 ` peter.ujfalusi
2010-12-23 7:32 ` peter.ujfalusi
2010-12-23 14:39 ` Liam Girdwood
2010-12-21 13:57 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012071052.56009.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=magi.olaya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox