From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ASoC: tlv320dac33: Move DACL/R power on to PGA widget
Date: Wed, 8 Dec 2010 13:41:31 +0000 [thread overview]
Message-ID: <20101208134131.GK16418@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291813977-17944-2-git-send-email-peter.ujfalusi@nokia.com>
On Wed, Dec 08, 2010 at 03:12:57PM +0200, Peter Ujfalusi wrote:
> + SND_SOC_DAPM_PGA("Left DAC Power", DAC33_LDAC_PWR_CTRL, 2, 0, NULL, 0),
> + SND_SOC_DAPM_PGA("Right DAC Power", DAC33_RDAC_PWR_CTRL, 2, 0, NULL, 0),
These feels like they should be supply widgets for the output amps?
Might be a bit clearer.
next prev parent reply other threads:[~2010-12-08 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 13:12 [PATCH 1/2] ASoC: tlv320dac33: Fix compillation error Peter Ujfalusi
2010-12-08 13:12 ` [PATCH 2/2] ASoC: tlv320dac33: Move DACL/R power on to PGA widget Peter Ujfalusi
2010-12-08 13:41 ` Mark Brown [this message]
2010-12-08 13:52 ` Peter Ujfalusi
2010-12-08 13:39 ` [PATCH 1/2] ASoC: tlv320dac33: Fix compillation error Mark Brown
2010-12-09 9:45 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208134131.GK16418@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox