From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Zeng Zhaoming <zhaoming.zeng@freescale.com>
Cc: s.hauer@pengutronix.de, festevam@gmail.com,
alsa-devel@alsa-project.org, arnaud.patard@rtp-net.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] asoc, codec: Add SGTL5000 codec support to asoc
Date: Thu, 9 Dec 2010 12:15:14 +0000 [thread overview]
Message-ID: <20101209121514.GC4469@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20101208192235.GA24928@ubuntu.localdomain>
On Thu, Dec 09, 2010 at 03:22:35AM +0800, Zeng Zhaoming wrote:
> On Wed 2010-12-08 05:11:55, Mark Brown wrote:
> > On Wed, Dec 08, 2010 at 10:06:29AM +0800, zhaoming.zeng@freescale.com
> > > + sgtl5000_set_bias_level(codec, codec->suspend_bias_level);
> > The CODEC will never be in any state above STANDBY at suspend.
> Is there any documentation describe the state machine?
Not outside the source code.
> > > + msleep(1);
> > This delay looks like it's in the wrong place?
> The SGTL5000 has an internal reset that is deasserted 8 SYS_MCLK cycles after
> all power rails have been brought up. After this time communication can start.
>
> So I think delay 1ms is safe for the next operations.
It needs to be tied much more clearly to the enables, then - that's not
clear at the minute, especially given that there's no code in the same
function that interacts with the hardware.
next prev parent reply other threads:[~2010-12-09 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 2:06 [PATCH] asoc, codec: Add SGTL5000 codec support to asoc zhaoming.zeng
2010-12-08 12:11 ` Mark Brown
2010-12-08 19:22 ` Zeng Zhaoming
2010-12-09 12:15 ` Mark Brown [this message]
2010-12-08 17:26 ` Arnaud Patard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209121514.GC4469@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=festevam@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=s.hauer@pengutronix.de \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox