Re: [PATCH v2 02/16] ASoC: twl6040: Modify the IRQ handler

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Fri, Dec 10, 2010 at 09:05:30PM -0600, Olaya, Margarita wrote:
> Multiples interrupts can be received. The irq handler is modified
> to attend all of them.
> 
> Signed-off-by: Margarita Olaya Cabrera <magi.olaya@ti.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> -	case TWL6040_PLUGINT:
> -	case TWL6040_UNPLUGINT:
> +
> +	if ((intid & TWL6040_PLUGINT) || (intid & TWL6040_UNPLUGINT))
>  		queue_delayed_work(priv->workqueue, &priv->delayed_work,
>  							msecs_to_jiffies(200));
> -		break;

This is going to collide with your previous patch series to enable jack
detection.

> +	if (intid & TWL6040_HOOKINT)
> +		dev_info(codec->dev, "hook detection\n");
> +

This should be reported via the jack detection API - this would
generally be shown as a button to userspace.

>  
>  	return IRQ_HANDLED;
>  }

I'd still expect to see this only flagged if at least one of the
interrupt sources fired.