From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences
Date: Fri, 17 Dec 2010 09:08:41 +0200 [thread overview]
Message-ID: <201012170908.42046.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20101216135505.GA1344@sirena.org.uk>
On Thursday 16 December 2010 15:55:05 ext Mark Brown wrote:
> On Thu, Dec 16, 2010 at 03:51:13PM +0200, Peter Ujfalusi wrote:
> > It behaves mostly OK, but there's a strange side effect:
> > I noticed a pop on playback stream start on the twl4030 codec.
> > I'll look into it, but I do not see how this patch can affect the stream
> > start..
>
> Indeed, it should result in an extra comparison in the middle of the
> DAPM sequence which oughtn't to have any effect here. Is it possible
> that some of the other updates that have been going in recently such
> as the cross-device changes introduced this, or is it definitely just
> this one patch?
Found the reason..
The pop is there without this patch, it is coming from the output amp power up.
In normal use case, it is filtered by the external amp, but I use non
convetional setup at the moment, and that is the reason for the pop.
I need to take a look at this at some time :(
> > Could you hold this patch for some time, so I can look at this?
>
> Sure.
Thanks,
You can pick either of my:
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Tested-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
next prev parent reply other threads:[~2010-12-17 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 17:53 [PATCH 1/2] ASoC: Remove unused DAPM_DOUBLE control types Mark Brown
2010-12-14 17:53 ` [PATCH 2/2] ASoC: Do DAPM control updates in the middle of DAPM sequences Mark Brown
2010-12-16 8:39 ` Peter Ujfalusi
2010-12-16 13:03 ` Peter Ujfalusi
2010-12-16 13:51 ` Peter Ujfalusi
2010-12-16 13:55 ` Mark Brown
2010-12-17 7:08 ` Peter Ujfalusi [this message]
2010-12-17 11:45 ` Mark Brown
2010-12-15 13:37 ` [PATCH 1/2] ASoC: Remove unused DAPM_DOUBLE control types Liam Girdwood
2010-12-15 18:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012170908.42046.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox