From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 07/11] ASoC: tegra: Add tegra-das driver
Date: Wed, 22 Dec 2010 20:11:18 +0000 [thread overview]
Message-ID: <20101222201118.GA8167@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF030FD78D90@HQMAIL01.nvidia.com>
On Wed, Dec 22, 2010 at 10:30:15AM -0800, Stephen Warren wrote:
> Mark Brown wrote:
> > Reading this it's essentially just exporting point to point switches
> > within the DAS block. This really feels like it ought to be represented
> > as a CODEC driver to give runtime flexibility to userspace to control
> > the mux - it looks like the AP part of the system streams data into this
> > block which then has very flexible switching on to the externally
> > connected audio devices.
> Hmm. I don't see any examples of anything like Tegra's DAS in the existing
> ASoC code-base. So, I'm slightly unsure how to recast the DAS driver as
> a codec. In particular, in the machine driver, would I do something like:
The closest thing in the tree at the minute is WM8994 and WM8995 - both
of these have multiple audio interfaces plus a DAC/ADC/DMIC block
connected together via a digital mixing block.
> static struct snd_soc_dai_link *harmony_links[] = {
> & harmony_i2s_das_link,
> & harmony_das_wm8903_link,
> };
Essentially, yes.
> Wouldn't that end up exposing two streams to user-space, one for each entry
> in harmony_links[]?
Yeah, that's the unfortunate bit - it doesn't work ideally well right
now. We actually need to take care of this anyway (it's also an issue
for things like phones as you get the same structure for the link
between a digital baseband and the CODEC it's connected to) and
something like this that really strongly benefits from the feature would
be a good thing to use to get that working.
I guess for now setting up a 1:1 mapping between the CPU DAIs and the
physical ports would get the CPU driver going, then I can do the
framework work required to make sure DAPM propagates nicely over the
mux. Does that sound reasonable?
next prev parent reply other threads:[~2010-12-22 20:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1292622090-21896-1-git-send-email-swarren@nvidia.com>
[not found] ` <1292622090-21896-8-git-send-email-swarren@nvidia.com>
[not found] ` <20101217220029.GD25609@sirena.org.uk>
2010-12-22 18:30 ` [PATCH 07/11] ASoC: tegra: Add tegra-das driver Stephen Warren
2010-12-22 20:11 ` Mark Brown [this message]
2011-01-05 22:58 ` Stephen Warren
2011-01-05 23:18 ` Mark Brown
2011-01-05 23:27 ` Stephen Warren
2011-01-05 23:33 ` Mark Brown
2011-01-06 0:20 ` Stephen Warren
2011-01-06 0:59 ` Mark Brown
2011-01-06 17:46 ` Stephen Warren
2011-01-06 21:02 ` Mark Brown
2011-01-06 21:58 ` Stephen Warren
2011-01-06 22:13 ` Mark Brown
[not found] ` <1292622090-21896-9-git-send-email-swarren@nvidia.com>
[not found] ` <20101217220658.GG25609@sirena.org.uk>
2010-12-22 19:03 ` [PATCH 08/11] ASoC: tegra: Add tegra-pcm driver Stephen Warren
2010-12-22 20:16 ` Mark Brown
[not found] ` <1292622090-21896-11-git-send-email-swarren@nvidia.com>
[not found] ` <20101217222636.GJ25609@sirena.org.uk>
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF030FD7885D@HQMAIL01.nvidia.com>
[not found] ` <20101217230618.GA28364@sirena.org.uk>
[not found] ` <20101220211131.GG14986@sirena.org.uk>
2010-12-23 1:13 ` [PATCH 10/11] ASoC: tegra: Harmony machine support Stephen Warren
2010-12-23 2:19 ` Mark Brown
2011-01-03 19:39 ` Stephen Warren
2011-01-04 15:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222201118.GA8167@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).